-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 Single & Mult-Select + Dropdown {Component} #3856
Comments
Redesigning the multi-select For example, the custom 'chip' with user avatar is not directly supported by react-select and requires a workaround where we have to create a component to pass it through. |
I'm open to discussing changes to the designs if there is something we can do that is supported that is reasonable and meets the same need. We don't need the custom chip with avatar for example. Let's just drop it. But the prime demo also looks good. However, I'm definitely not the one to make the call on whether using something like this is a good call in the long run. |
Yep, makes sense. I think that if we are to keep react select for now, maybe we can make changes to the design for the interim period where we make it look more part of the V2 theme for the moment, and then we can give it the time it needs to convert it to the final design as a follow up. What do you think? |
It is, yeah @Jaibles. Also, I checked through quick changes that the cross button with each name isn't quite working well either, although this could simply be a minor bug, but a bug nonetheless. |
Tldr; I would definitely aim to have it done as per the final designs, but I don't know if we have the time (unless someone can confirm that they do). |
Do you mean the remove icon? Could we just allow removing by opening the dropdown and clicking again to deselect as a temporary fix? |
Yeah, so the remove icon for each user doesn't work, the main remove icon doesn't work either (can't click). I'll have a go at it with the suggested changes, and see if I can get it to work in a partial state, report back with my findings 🙏 If I do get it to work at all, I will then try to accommodate the |
Select in Figma | Select Dropdown in Figma
The text was updated successfully, but these errors were encountered: