Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Single & Mult-Select + Dropdown {Component} #3856

Closed
ciaranha opened this issue Aug 15, 2022 · 8 comments · Fixed by #4324
Closed

2.0 Single & Mult-Select + Dropdown {Component} #3856

ciaranha opened this issue Aug 15, 2022 · 8 comments · Fixed by #4324
Assignees
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI
Milestone

Comments

@ciaranha
Copy link
Member

ciaranha commented Aug 15, 2022

Select in Figma | Select Dropdown in Figma

Image

@ciaranha ciaranha added this to the v.2.0 milestone Aug 15, 2022
@PeerRich PeerRich added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Aug 19, 2022
@alishaz-polymath
Copy link
Member

alishaz-polymath commented Sep 2, 2022

Redesigning the multi-select selectbox according to the figma designs requires quite a bit of overhead. Thoughts on using https://www.primefaces.org/primereact/multiselect/ for that purpose instead? Looks like a decent solution that meets our needs from the looks of it. If we're not against the idea of using this, I can test it out locally to see how it works, otherwise will keep looking for the solutions in react-select 🙏

For example, the custom 'chip' with user avatar is not directly supported by react-select and requires a workaround where we have to create a component to pass it through.
Also note that if we were to go ahead with this, we'd simply be replacing the react-select node_module with this one
CC: @PeerRich @Jaibles

@ciaranha
Copy link
Member Author

ciaranha commented Sep 2, 2022

I'm open to discussing changes to the designs if there is something we can do that is supported that is reasonable and meets the same need. We don't need the custom chip with avatar for example. Let's just drop it.

But the prime demo also looks good. However, I'm definitely not the one to make the call on whether using something like this is a good call in the long run.

@alishaz-polymath
Copy link
Member

I'm open to discussing changes to the designs if there is something we can do that is supported that is reasonable and meets the same need. We don't need the custom chip with avatar for example. Let's just drop it.

But the prime demo also looks good. However, I'm definitely not the one to make the call on whether using something like this is a good call in the long run.

Yep, makes sense. I think that if we are to keep react select for now, maybe we can make changes to the design for the interim period where we make it look more part of the V2 theme for the moment, and then we can give it the time it needs to convert it to the final design as a follow up. What do you think?

@ciaranha
Copy link
Member Author

ciaranha commented Sep 2, 2022

Sounds good to me. Avatars are gone. Where else do we need to make changes? The "2 more" part tricky?
CleanShot 2022-09-02 at 09 36 34@2x

@alishaz-polymath
Copy link
Member

The "2 more" part tricky?

It is, yeah @Jaibles. Also, I checked through quick changes that the cross button with each name isn't quite working well either, although this could simply be a minor bug, but a bug nonetheless.
I mean I would think that it is best to accommodate it the way it is right now and just make it not feel out of place from the design. And then someone works at it for the final design (ps. I could take it up as well). I just feel we might not have the time, unless there's someone who can take it up before then.

@alishaz-polymath
Copy link
Member

Tldr; I would definitely aim to have it done as per the final designs, but I don't know if we have the time (unless someone can confirm that they do).

@ciaranha
Copy link
Member Author

ciaranha commented Sep 2, 2022

cross button

Do you mean the remove icon? Could we just allow removing by opening the dropdown and clicking again to deselect as a temporary fix?

@alishaz-polymath
Copy link
Member

alishaz-polymath commented Sep 2, 2022

Do you mean the remove icon? Could we just allow removing by opening the dropdown and clicking again to deselect as a temporary fix?

Yeah, so the remove icon for each user doesn't work, the main remove icon doesn't work either (can't click). I'll have a go at it with the suggested changes, and see if I can get it to work in a partial state, report back with my findings 🙏 If I do get it to work at all, I will then try to accommodate the +2 more as well

@alishaz-polymath alishaz-polymath moved this from Todo to In Progress in Cal.com Core Roadmap Sep 8, 2022
Repository owner moved this from In Progress to Done in Cal.com Core Roadmap Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants