Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty spaces in text field do not trigger inline field error #10038

Merged
merged 4 commits into from
Jul 11, 2023
Merged

fix: Empty spaces in text field do not trigger inline field error #10038

merged 4 commits into from
Jul 11, 2023

Conversation

greatmaxy
Copy link
Contributor

What does this PR do?

Fixes - empty spaces in text field do not trigger inline field error

Fixes #10028

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Schedule any meeting
  • Give empty spaces in your name section
  • "Invalid input" error is displayed

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 4:55am

@vercel
Copy link

vercel bot commented Jul 10, 2023

@greatmaxy is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🐛 bug Something isn't working labels Jul 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@greatmaxy greatmaxy changed the title fix:Empty spaces in text field do not trigger inline field error fix: Empty spaces in text field do not trigger inline field error Jul 10, 2023
@greatmaxy greatmaxy marked this pull request as ready for review July 10, 2023 11:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jul 10, 2023
CarinaWolli
CarinaWolli approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank your contribution 🙏

@CarinaWolli CarinaWolli merged commit db27c7e into calcom:main Jul 11, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@greatmaxy @fritterhoff
fix: Empty spaces in text field do not trigger inline field error (ca…
101ec09 
…lcom#10038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty Spaces in Text Field Do Not Trigger Inline Field Error
3 participants
@greatmaxy @CarinaWolli @PeerRich