fix: loading animation of update buttons #13131
Conversation
|
|
|
@moulibrota-das is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
moulibrota-das
changed the title
There was a problem hiding this comment.
@moulibrota-das no need to create a state variable. try to use formState.isSubmitting from react hook form. (check isBrandColorsFormSubmitting, isBookerLayoutFormSubmitting)
|
@Udit-takkar I was making the suggested changes and found that the formState.isSubmitting is not working properly in those forms and always returning false value. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| @@ -184,6 +187,7 @@ const AppearanceView = ({ | |||
| </div> | |||
| <SectionBottomActions className="mb-6" align="end"> | |||
| <Button | |||
| loading={mutation.isLoading} | |||
There was a problem hiding this comment.
Since this is a mutation, you have to use mutation.isPending.
There was a problem hiding this comment.
Made the suggested changes
PeerRich
dismissed stale reviews from joeauyeung and Udit-takkar
rereview please
What does this PR do?
This PR fixes the loading animation in update buttons located in the appearance settings page.
Fixes #13110 (issue)
Screencast.from.09-01-24.11.32.56.PM.IST.webm
Type of change