Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefill avatar when signing up #13427

Merged
merged 2 commits into from
Jan 27, 2024
Merged

fix: prefill avatar when signing up #13427

merged 2 commits into from
Jan 27, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Jan 26, 2024

What does this PR do?

prefills avatar when signing up if it exists

Fixes #13426

Type of change

  • Bug fix (non-breaking change which fixes an issue)

/claim #13426

Copy link

vercel bot commented Jan 26, 2024

@neo773 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 26, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 26, 2024
@PeerRich PeerRich requested a review from emrysal January 27, 2024 10:12
@@ -788,6 +788,7 @@ export const AUTH_OPTIONS: AuthOptions = {
username: orgId ? slugify(orgUsername) : usernameSlug(user.name),
emailVerified: new Date(Date.now()),
name: user.name,
...(user.image && { avatarUrl: user.image }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would save the google URL right? I wonder if we should convert this to base64 and save on our server? 🤔 @emrysal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think saving the URL should be fine as it's static and never expires

@PeerRich PeerRich merged commit 6643d3c into calcom:main Jan 27, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim community Created by Linear-GitHub Sync ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3036] prefill avatar when signing up with Google
3 participants