fix: prefill avatar when signing up #13427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neo773 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
reviewed
Jan 27, 2024
| @@ -788,6 +788,7 @@ export const AUTH_OPTIONS: AuthOptions = { | |||
| username: orgId ? slugify(orgUsername) : usernameSlug(user.name), | |||
| emailVerified: new Date(Date.now()), | |||
| name: user.name, | |||
| ...(user.image && { avatarUrl: user.image }), | |||
There was a problem hiding this comment.
this would save the google URL right? I wonder if we should convert this to base64 and save on our server? 🤔 @emrysal
There was a problem hiding this comment.
yeah, I think saving the URL should be fine as it's static and never expires
PeerRich
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
prefills avatar when signing up if it exists
Fixes #13426
Type of change
/claim #13426