Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure event type duplication respects private link setting #13438

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Jan 28, 2024

What does this PR do?

Fixes #13389

Copy link

vercel bot commented Jan 28, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 28, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 28, 2024
Copy link
Contributor

github-actions bot commented Jan 28, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v3.9 milestone Jan 28, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 28, 2024
@github-actions github-actions bot added the High priority Created by Linear-GitHub Sync label Jan 29, 2024
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work as always Somay! 🚀

I can confirm that your fix works - duplicated event types have the secret URL setup.

However, small comment below about code re-usage. Let me know what you think.

@SomayChauhan SomayChauhan marked this pull request as draft February 6, 2024 13:27
@SomayChauhan SomayChauhan marked this pull request as ready for review February 6, 2024 16:43
@keithwillcode keithwillcode enabled auto-merge (squash) February 7, 2024 05:18
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works! Great stuff! 🚀

@keithwillcode keithwillcode merged commit a0451e3 into calcom:main Feb 7, 2024
30 of 38 checks passed
@keithwillcode keithwillcode modified the milestones: v3.9, v3.8 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync event-types area: event types, event-types High priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3001] Duplicating an event type doesn't duplicate advanced settings
3 participants