-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure event type duplication respects private link setting #13438
fix: Ensure event type duplication respects private link setting #13438
Conversation
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work as always Somay! 🚀
I can confirm that your fix works - duplicated event types have the secret URL setup.
However, small comment below about code re-usage. Let me know what you think.
packages/trpc/server/routers/viewer/eventTypes/duplicate.handler.ts
Outdated
Show resolved
Hide resolved
…nt having private-link switched on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works! Great stuff! 🚀
What does this PR do?
Fixes #13389
A separate issue [CAL-3042] Odd behavior on copy and on changing calendar #13417 has alredy been created for that
The calendar the event is tied to (always goes back to default).