feat: round-robin priority ranking #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 112 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/08/2024 04:25:17pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: dadc2bf Started: 02/08/2024 04:19:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 323 runsfailed over last 7 days |
4.64% (15)15 / 323 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group required and Short Text required
Retry 1 • Initial Attempt |
0% (0)0 / 325 runsfailed over last 7 days |
5.23% (17)17 / 325 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Question Address required and checkbox required
Retry 2 • Retry 1 • Initial Attempt |
1.73% (6)6 / 346 runsfailed over last 7 days |
4.62% (16)16 / 346 runsflaked over last 7 days |
github-actions
bot
added
Medium priority
Udit-takkar
reviewed
Feb 8, 2024
No that's currently not possible, all hosts will have medium priority. I can revisit that in a follow-up |
emrysal
reviewed
Feb 8, 2024
Udit-takkar
reviewed
Feb 9, 2024
| @@ -41,6 +41,7 @@ model Host { | |||
| eventType EventType @relation(fields: [eventTypeId], references: [id], onDelete: Cascade) | |||
| eventTypeId Int | |||
| isFixed Boolean @default(false) | |||
| priority Int? | |||
There was a problem hiding this comment.
can we just add a default value of 2 here?
Udit-takkar
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
@CarinaWolli LGTM. Awesome work
I'll wait for Alex review before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds priority ranking to round-robin: Every round-robin host has a priority, by default 'medium'. Until now round-robin booked the least recently booked available users. Now it will book the available user with the highest priority, if several users have the same priority it will choose the least recently booked user.
Also, adds some design changes to the assignment tab of event-type settings as it had several design issues. @ciaranha not sure if we have a final figma design, but I used this Figma Design. I am open for feedback, here's how it looks:
Clickable priority label on round-robin host (sorted hosts):
Dialog to change priority:
Activate fixed hosts on round-robin event
Collective Event
Enable 'Assign all team members'
Fixes #11545
Type of change