fix: org user event types with same event slug #13571
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
exception
approved these changes
Feb 6, 2024
joeauyeung
approved these changes
Feb 6, 2024
zomars
approved these changes
Feb 6, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 440 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/06/2024 10:48:18pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 10a4b4f Started: 02/06/2024 10:38:36pm UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email and Address not required
Retry 1 • Initial Attempt |
2.80% (9)9 / 321 runsfailed over last 7 days |
3.74% (12)12 / 321 runsflaked over last 7 days |
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox group Question Multiple Email and checkbox group not required
Retry 1 • Initial Attempt |
2.80% (9)9 / 322 runsfailed over last 7 days |
5.90% (19)19 / 322 runsflaked over last 7 days |
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Long text Question Multiple Email required and Long text required
Retry 1 • Initial Attempt |
0.32% (1)1 / 310 runfailed over last 7 days |
7.10% (22)22 / 310 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Long Text and Address required
Retry 1 • Initial Attempt |
0.33% (1)1 / 299 runfailed over last 7 days |
5.02% (15)15 / 299 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and multiselect Question Long Text required and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
2.69% (8)8 / 297 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required
Retry 1 • Initial Attempt |
0.34% (1)1 / 297 runfailed over last 7 days |
4.04% (12)12 / 297 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Short text question Long Text and Short text required
Retry 1 • Initial Attempt |
0% (0)0 / 292 runsfailed over last 7 days |
4.11% (12)12 / 292 runsflaked over last 7 days |
📄 apps/web/playwright/booking/collectiveEventType/collectiveEventType.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Collective event type Book a Collective event type (with added guest)
Retry 1 • Initial Attempt |
0% (0)0 / 294 runsfailed over last 7 days |
2.72% (8)8 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
5.67% (17)17 / 300 runsfailed over last 7 days |
37% (111)111 / 300 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Phone Question Radio and Phone not required
Retry 1 • Initial Attempt |
0.34% (1)1 / 293 runfailed over last 7 days |
4.44% (13)13 / 293 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail Org Invitation
Retry 2 • Retry 1 • Initial Attempt |
13.42% (42)42 / 313 runsfailed over last 7 days |
6.07% (19)19 / 313 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
0.60% (2)2 / 332 runsfailed over last 7 days |
17.77% (59)59 / 332 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 315 runsfailed over last 7 days |
27.30% (86)86 / 315 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-3.16% (-10)-10 / 316 runsfailed over last 7 days |
50.32% (159)159 / 316 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-95.78% (-159)-159 / 166 runsfailed over last 7 days |
95.78% (159)159 / 166 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-84.94% (-141)-141 / 166 runsfailed over last 7 days |
87.35% (145)145 / 166 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-89.51% (-145)-145 / 162 runsfailed over last 7 days |
89.51% (145)145 / 162 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-89.51% (-145)-145 / 162 runsfailed over last 7 days |
89.51% (145)145 / 162 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-89.51% (-145)-145 / 162 runsfailed over last 7 days |
89.51% (145)145 / 162 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-89.51% (-145)-145 / 162 runsfailed over last 7 days |
89.51% (145)145 / 162 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-89.51% (-145)-145 / 162 runsfailed over last 7 days |
89.51% (145)145 / 162 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.32% (1)1 / 314 runfailed over last 7 days |
40.76% (128)128 / 314 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and checkbox group Question Phone required and checkbox group not required
Retry 1 • Initial Attempt |
0.65% (2)2 / 309 runsfailed over last 7 days |
3.88% (12)12 / 309 runsflaked over last 7 days |
Shyam-Raghuwanshi
pushed a commit
to Shyam-Raghuwanshi/cal.com
that referenced
this pull request
Feb 7, 2024
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When org members had the same event slugs wrong event types were shown on org event type links (
acme.cal.local:3000/user/slug)