Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: troubleshooter scroll #13631

Merged
merged 1 commit into from
Feb 10, 2024
Merged

fix: troubleshooter scroll #13631

merged 1 commit into from
Feb 10, 2024

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Feb 10, 2024 •
edited
Loading

fixes: #12751

Other PRs: #13611

Massive shout out to @AsbarK for giving me inspo for pushing a fix for this.

Fixes scroll:

CleanShot 2024-02-10 at 14 56 25

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 7:01am
api 🔄 Building (Inspect) Visit Preview Feb 10, 2024 7:01am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 10, 2024 7:01am
cal-demo ⬜️ Ignored (Inspect) Feb 10, 2024 7:01am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2024 7:01am
ui ⬜️ Ignored (Inspect) Feb 10, 2024 7:01am

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync ✅ good first issue Good for newcomers 🐛 bug Something isn't working labels Feb 10, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 10, 2024
@sean-brydon sean-brydon mentioned this pull request Feb 10, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Feb 10, 2024 •
edited
Loading

No failed tests 🎉

PeerRich
PeerRich approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works!

@PeerRich PeerRich merged commit 6adb5b4 into main Feb 10, 2024
40 checks passed
@PeerRich PeerRich deleted the feat/fix-scroll branch February 10, 2024 19:26
keithwillcode pushed a commit that referenced this pull request Feb 12, 2024
@sean-brydon @keithwillcode
fix: troubleshooter scroll (#13631)
5ea0f98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer core area: core, team members only ✅ good first issue Good for newcomers High priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-2796] Troubleshooter - Vertical scrolling not working on left panel or calendar
3 participants
@sean-brydon @PeerRich @keithwillcode