Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix types in apps/swagger (fixes #10023 and required for successful Railway build) #13639

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

stabildev
Copy link
Contributor

@stabildev stabildev commented Feb 12, 2024

(Reimplementation of #12681)

What does this PR do?

Fix some typing issues in apps/swagger that cause Railway build to fail.

Should also fix #10023

Notes

  • Renamed snippets.ts to snippets.js as it doesn't contain the necessary types which leads to build errors on Railway. The types are not available.
  • Removed two non-existing props from index.tsx See here for syntaxHighlight prop

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Feb 12, 2024

@stabildev is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added ci area: CI, DX, pipeline, github actions Low priority Created by Linear-GitHub Sync Stale 🐛 bug Something isn't working labels Feb 12, 2024
Copy link

socket-security bot commented Feb 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/swagger-ui-react@4.18.3 None +4 1.44 MB types

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 12, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode requested a review from a team February 12, 2024 12:54
@keithwillcode keithwillcode added this to the v3.9 milestone Feb 12, 2024
@stabildev stabildev marked this pull request as ready for review February 12, 2024 13:25
@github-actions github-actions bot removed the Stale label Feb 13, 2024
@github-actions github-actions bot added Stale and removed Stale labels Feb 13, 2024
@github-actions github-actions bot added Stale and removed Stale labels Feb 16, 2024
@github-actions github-actions bot added the Stale label Feb 19, 2024
@keithwillcode keithwillcode merged commit c05f595 into calcom:main Feb 19, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ci area: CI, DX, pipeline, github actions foundation Low priority Created by Linear-GitHub Sync Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger App won't build
2 participants