fix: Add location to ics file
#13646
Merged
+143
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/13/2024 08:36:50am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 449c900 Started: 02/13/2024 08:28:20am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text and select required
Retry 1 • Initial Attempt |
0.39% (1)1 / 254 runfailed over last 7 days |
7.87% (20)20 / 254 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Checkbox Group required and Address required
Retry 1 • Initial Attempt |
0% (0)0 / 260 runsfailed over last 7 days |
6.15% (16)16 / 260 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and multiselect Question Checkbox Group and multiselect text not required
Retry 1 • Initial Attempt |
0% (0)0 / 257 runsfailed over last 7 days |
5.84% (15)15 / 257 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Number Question Checkbox Group and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 256 runsfailed over last 7 days |
7.03% (18)18 / 256 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
3.20% (8)8 / 250 runsfailed over last 7 days |
39.20% (98)98 / 250 runsflaked over last 7 days |
|
Login and logout tests -- legacy Login flow validations -- legacy Should warn when user does not exist
Retry 1 • Initial Attempt |
0% (0)0 / 248 runsfailed over last 7 days |
4.03% (10)10 / 248 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
11.95% (19)19 / 159 runsfailed over last 7 days |
51.57% (82)82 / 159 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Number Question Address and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 262 runsfailed over last 7 days |
4.58% (12)12 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization Org Invitation
Retry 1 • Initial Attempt |
1.95% (5)5 / 256 runsfailed over last 7 days |
6.25% (16)16 / 256 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone required and Long text not required
Retry 1 • Initial Attempt |
0.38% (1)1 / 262 runfailed over last 7 days |
7.63% (20)20 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0.74% (2)2 / 271 runsfailed over last 7 days |
11.44% (31)31 / 271 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.76% (2)2 / 263 runsfailed over last 7 days |
44.49% (117)117 / 263 runsflaked over last 7 days |
zomars
reviewed
Feb 12, 2024
| @@ -176,7 +179,7 @@ export const buildCalendarEvent = (event?: Partial<CalendarEvent>): CalendarEven | |||
| customInputs: {}, | |||
| additionalNotes: faker.lorem.paragraph(), | |||
| organizer: buildPerson(), | |||
| videoCallData: buildVideoCallData(), | |||
| ...(!omitVideoCallData && { videoCallData: buildVideoCallData() }), | |||
There was a problem hiding this comment.
Just curious. Why is this needed?
There was a problem hiding this comment.
When generating the ics string we look for video call data first and then the location. Since video call data was always included in the event builder the ics string would always fallback to the video call url.
PeerRich
previously approved these changes
Feb 12, 2024
keithwillcode
added
High priority
Udit-takkar
reviewed
Feb 13, 2024
Udit-takkar
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
LOCATIONfield to the ics file Cal.com generates.Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
LOCATIONfield should be includedMandatory Tasks