Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CAL-3141] (+1) badge not aligned #13718

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

jackWhtman
Copy link
Contributor

What does this PR do?

Updated the class names for AvatarGroup elements to align the +n badge

Fixes #13688

Requirement/Documentation

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

For a group of users when Avatar's are rendered on screen they should be aligned

  • What are the minimal test data to have?
    • to have at least more than 4 users for this scenario
  • What is expected (happy path) to have (input and output)?
    • all badge elements to be aligned

Checklist

  • I haven't checked if new and existing unit tests pass locally with my changes

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 16, 2024
Copy link

vercel bot commented Feb 16, 2024

@jackWhtman is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers 🐛 bug Something isn't working 🙋🏻‍♂️help wanted Help from the community is appreciated labels Feb 16, 2024
Copy link

graphite-app bot commented Feb 16, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/16/24)

1 label was added based on Keith Williams's automation, 'Add community label'

@jackWhtman jackWhtman changed the title Fixes [CAL-3141] (+1) badge not aligned Fix: [CAL-3141] (+1) badge not aligned Feb 16, 2024
@jackWhtman jackWhtman changed the title Fix: [CAL-3141] (+1) badge not aligned fix: [CAL-3141] (+1) badge not aligned Feb 16, 2024
Copy link
Contributor

github-actions bot commented Feb 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Udit-takkar Udit-takkar requested a review from a team February 16, 2024 07:40
@Udit-takkar Udit-takkar added this to the v3.9 milestone Feb 16, 2024
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Text wasn't centered so I have fixed that also
Screenshot 2024-02-16 at 1 42 55 PM

@Udit-takkar Udit-takkar enabled auto-merge (squash) February 16, 2024 08:13
@Udit-takkar Udit-takkar merged commit 26d7301 into calcom:main Feb 16, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ✅ good first issue Good for newcomers 🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3141] (+1) badge not aligned
3 participants