Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add toast and tooltip #13724

Merged
merged 2 commits into from
Feb 16, 2024
Merged

chore: add toast and tooltip #13724

merged 2 commits into from
Feb 16, 2024

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Screen.Recording.2024-02-16.at.3.59.02.PM.mov

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

@graphite-app graphite-app bot requested a review from a team February 16, 2024 10:29
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@Udit-takkar Udit-takkar added this to the v3.9 milestone Feb 16, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 16, 2024
@Udit-takkar Udit-takkar changed the title Chore/add toast chore: add toast and tooltip Feb 16, 2024
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:32am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 16, 2024 10:32am
calcom-web-canary ⬜️ Ignored (Inspect) Feb 16, 2024 10:32am

Copy link

graphite-app bot commented Feb 16, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/16/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 16, 2024

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 18 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/16/2024 10:52:29am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: bf53de6

Started: 02/16/2024 10:41:44am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Long text Question Multiple Email and Long text not required
Retry 1Initial Attempt
0% (0) 0 / 227 runs
failed over last 7 days
4.41% (10) 10 / 227 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and select Question Multiple Email required and select required
Retry 1Initial Attempt
0% (0) 0 / 227 runs
failed over last 7 days
6.61% (15) 15 / 227 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
prefill -- future logged in
Retry 1Initial Attempt
0% (0) 0 / 228 runs
failed over last 7 days
5.26% (12) 12 / 228 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1Initial Attempt
0.43% (1) 1 / 233 run
failed over last 7 days
8.15% (19) 19 / 233 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Multi email Question Checkbox Group and Multi email not required
Retry 1Initial Attempt
0.43% (1) 1 / 231 run
failed over last 7 days
6.06% (14) 14 / 231 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Number Question Checkbox Group and Number not required
Retry 1Initial Attempt
0% (0) 0 / 231 runs
failed over last 7 days
6.49% (15) 15 / 231 runs
flaked over last 7 days

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox Question Select required and checkbox required
Retry 1Initial Attempt
0% (0) 0 / 231 runs
failed over last 7 days
5.63% (13) 13 / 231 runs
flaked over last 7 days
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select required and select required
Retry 1Initial Attempt
0% (0) 0 / 231 runs
failed over last 7 days
6.06% (14) 14 / 231 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Number Question Radio required and Number required
Retry 1Initial Attempt
0.43% (1) 1 / 233 run
failed over last 7 days
4.72% (11) 11 / 233 runs
flaked over last 7 days
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Phone Question Radio required and Phone required
Retry 1Initial Attempt
0% (0) 0 / 233 runs
failed over last 7 days
4.72% (11) 11 / 233 runs
flaked over last 7 days
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Short text question Radio and Short text not required
Retry 1Initial Attempt
0% (0) 0 / 232 runs
failed over last 7 days
5.17% (12) 12 / 232 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 1Initial Attempt
0% (0) 0 / 235 runs
failed over last 7 days
9.36% (22) 22 / 235 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Can manage single schedule
Retry 1Initial Attempt
0.41% (1) 1 / 241 run
failed over last 7 days
7.47% (18) 18 / 241 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
12% (30) 30 / 250 runs
failed over last 7 days
51.60% (129) 129 / 250 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0% (0) 0 / 240 runs
failed over last 7 days
15% (36) 36 / 240 runs
flaked over last 7 days

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
15.23% (37) 37 / 243 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0% (0) 0 / 246 runs
failed over last 7 days
41.46% (102) 102 / 246 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 245 runs
failed over last 7 days
12.65% (31) 31 / 245 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode merged commit 8617f43 into main Feb 16, 2024
39 of 40 checks passed
@keithwillcode keithwillcode deleted the chore/add-toast branch February 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants