fix: Old username link on org user's profile. #13753
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
hariombalhara
changed the title
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/19/2024 01:33:57pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 6e1bdd6 Started: 02/19/2024 01:22:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox Question Multiple Email required and checkbox required
Retry 1 • Initial Attempt |
0.44% (1)1 / 225 runfailed over last 7 days |
5.33% (12)12 / 225 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and multiselect Question Long Text and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 226 runsfailed over last 7 days |
2.65% (6)6 / 226 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and select Question Checkbox Group required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 227 runsfailed over last 7 days |
4.85% (11)11 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
4.33% (10)10 / 231 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select required and Long text required
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
6.49% (15)15 / 231 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and multiselect Question Select required and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
4.33% (10)10 / 231 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.43% (1)1 / 231 runfailed over last 7 days |
44.16% (102)102 / 231 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Addres required and Long Text required
Retry 1 • Initial Attempt |
2.11% (5)5 / 237 runsfailed over last 7 days |
4.64% (11)11 / 237 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address required and Multi email required
Retry 1 • Initial Attempt |
0.43% (1)1 / 233 runfailed over last 7 days |
6.44% (15)15 / 233 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Phone Question Address required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 232 runsfailed over last 7 days |
9.91% (23)23 / 232 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests Add webhook on event type config Booking rescheduled
Retry 1 • Initial Attempt |
1.24% (3)3 / 242 runsfailed over last 7 days |
3.72% (9)9 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 237 runsfailed over last 7 days |
17.30% (41)41 / 237 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
1.61% (4)4 / 248 runsfailed over last 7 days |
49.60% (123)123 / 248 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0% (0)0 / 243 runsfailed over last 7 days |
42.39% (103)103 / 243 runsflaked over last 7 days |
hariombalhara
commented
Feb 19, 2024
| @@ -155,7 +155,7 @@ export function UserPage(props: InferGetServerSidePropsType<typeof getServerSide | |||
| <Link | |||
| prefetch={false} | |||
| href={{ | |||
| pathname: `/${user.username}/${type.slug}`, | |||
| pathname: `/${user.profile.username}/${type.slug}`, | |||
There was a problem hiding this comment.
Profile.username is supposed to have the correct username for an org member as well as non org member.
PeerRich
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before:
After:
Fixes https://calcominc.slack.com/archives/C05V243E153/p1708111917971829.
Note: this bug occurs only for the existing users that are invited to an organization and doesn't occur for migrated users that are migrated through migration script. This is because migration script changes user.username but invitation logic only sets the correct username in profile.username
Type of change
How should this be tested?
Mandatory Tasks
Checklist
Test followup in #13754