feat: signup redirect query param after onboarding #13761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
sean-brydon
commented
Feb 19, 2024
| } | ||
| await utils.viewer.me.refetch(); | ||
| const redirectUrl = localStorage.getItem("onBoardingRedirect"); | ||
| localStorage.removeItem("onBoardingRedirect"); |
There was a problem hiding this comment.
Remove from storage so this doesnt happen if the user onboards again for whatever reason.
sean-brydon
commented
Feb 19, 2024
Comment on lines
+30
to
+37
| const redirectUrlData = z | ||
| .string() | ||
| .refine((value) => value.startsWith(WEBAPP_URL), { | ||
| params: (value: string) => ({ value }), | ||
| message: "Redirect URL must start with 'cal.com'", | ||
| }) | ||
| .optional() | ||
| .safeParse(ctx.query.redirect); |
There was a problem hiding this comment.
Ensure this URL is only to WEBAPP
sean-brydon
commented
Feb 19, 2024
| .optional() | ||
| .safeParse(ctx.query.redirect); | ||
|
|
||
| const redirectUrl = redirectUrlData.success ? redirectUrlData.data : undefined; |
There was a problem hiding this comment.
If this fails - use undefined and don't throw error
Graphite AutomationsA Graphite automation took an action on this PR • (02/19/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/21/2024 02:11:22pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 899ad35 Started: 02/21/2024 02:01:11pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and Short text question Multiple Email and Short text not required
Retry 1 • Initial Attempt |
0% (0)0 / 222 runsfailed over last 7 days |
4.95% (11)11 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text and Checkbox Group required
Retry 1 • Initial Attempt |
0.45% (1)1 / 223 runfailed over last 7 days |
3.14% (7)7 / 223 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and multiselect Question Long Text and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 223 runsfailed over last 7 days |
4.93% (11)11 / 223 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group required and Phone required
Retry 1 • Initial Attempt |
0.43% (1)1 / 232 runfailed over last 7 days |
5.60% (13)13 / 232 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group and Short Text not required
Retry 1 • Initial Attempt |
0.89% (2)2 / 225 runsfailed over last 7 days |
6.22% (14)14 / 225 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.42% (1)1 / 236 runfailed over last 7 days |
42.80% (101)101 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Number Question Radio required and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 243 runsfailed over last 7 days |
4.53% (11)11 / 243 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone and Multi email required
Retry 1 • Initial Attempt |
0% (0)0 / 245 runsfailed over last 7 days |
5.71% (14)14 / 245 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 245 runsfailed over last 7 days |
3.67% (9)9 / 245 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Radio group Question Phone and Radio group required
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 245 runsfailed over last 7 days |
4.49% (11)11 / 245 runsflaked over last 7 days |
📄 apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With All Questions Selecting and filling all questions as optional
Retry 1 • Initial Attempt |
0% (0)0 / 232 runsfailed over last 7 days |
5.17% (12)12 / 232 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Can manage single schedule
Retry 2 • Retry 1 • Initial Attempt |
0.83% (2)2 / 240 runsfailed over last 7 days |
7.08% (17)17 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 243 runsfailed over last 7 days |
20.16% (49)49 / 243 runsflaked over last 7 days |
|
Event Types tests -- legacy user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 242 runsfailed over last 7 days |
4.13% (10)10 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should test download button
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
4.15% (10)10 / 241 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Phone Question Address required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 234 runsfailed over last 7 days |
8.12% (19)19 / 234 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-4.15% (-10)-10 / 241 runsfailed over last 7 days |
59.34% (143)143 / 241 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-115.74% (-125)-125 / 108 runsfailed over last 7 days |
119.44% (129)129 / 108 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-124.04% (-129)-129 / 104 runsfailed over last 7 days |
124.04% (129)129 / 104 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
16.60% (42)42 / 253 runsfailed over last 7 days |
48.62% (123)123 / 253 runsflaked over last 7 days |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Udit-takkar
reviewed
Feb 21, 2024
There was a problem hiding this comment.
@sean-brydon callbackUrl also does the same thing No it doesn't
o.o |
As discussed in DMs - will update here for history sake: callbackUrl happens straight after the user has signed up and this solution happens after onboarding. Me and Udit discussed in DMs that callbackUrl should probably do anyway - I will look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loom: https://www.loom.com/share/6fc8126dcac1402fba236a45a64c08ff
fixes: CAL-3054 #13460
Following the merge of this PR: https://github.com/calcom/website/pull/684 should also be merged to update pricing URL in website.