feat: Add {first name} variable to Organizer & Scheduler custom event… #14156
Conversation
|
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
event-types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/20/24)1 label was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 New Pages AddedThe following pages were added to the bundle from the code in this PR:
Thirteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
There was a problem hiding this comment.
Like mentioned in the issue, this should use the first name when split name is enabled.
Split name can be enabled in, Booking questions -> Advanced -> Booking question -> Edit name:
We should add {Scheduler first name} and {Scheduler last name} and use the values from the booking question
|
Should we only show those variables when split full name is checked? Or should we add some helper text that it will only work when you have set it to true? |
It would be best to only show them if split name is enabled |
|
Made changes @CarinaWolli. Also the issue was closed, is this still relevant? |
dosubot
bot
added
core
|
I reopened the issue, I think it's still nice to have |
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
| @@ -105,6 +113,8 @@ export const validateCustomEventName = ( | |||
| "{Organiser}", | |||
| "{Scheduler}", | |||
| "{Location}", | |||
| "{Organiser first name}", | |||
There was a problem hiding this comment.
as mentioned in #14156 (review), we wanted {Scheduler first name} and {Scheduler last name}
But you can leave {Organiser first name}, that's fine
There was a problem hiding this comment.
The issue stated first name, which is why I did not include last name. I will make changes to it.
calcom#14156) * feat: Add {first name} variable to Organizer & Scheduler custom event name * fix: use split name booking field * remove unwanted translation changes * Update packages/core/event.ts Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * chore: improve code * add scheduler last name --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Udit Takkar <udit222001@gmail.com>
What does this PR do?
Fixes #13974
Screen.Recording.2024-03-20.at.7.05.00.PM.mov
Type of change
Mandatory Tasks