Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Platform tidy up unused variables, etc #14289

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

exception
Copy link
Contributor

@exception exception commented Apr 2, 2024

Platform tidy up unused variables, etc

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Apr 2, 2024
@graphite-app graphite-app bot requested a review from a team April 2, 2024 12:24
Copy link

graphite-app bot commented Apr 2, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (04/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 9:54pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:54pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:54pm
qa ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:54pm

Copy link
Contributor

github-actions bot commented Apr 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 2, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/02/2024 10:05:41pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 56dd511

Started: 04/02/2024 10:02:28pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- future Time slots should be reserved when selected
Retry 2Retry 1Initial Attempt
0.47% (1) 1 / 213 run
failed over last 7 days
8.45% (18) 18 / 213 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Newly added secondary email should show as Unverified
Retry 1Initial Attempt
0% (0) 0 / 213 runs
failed over last 7 days
6.10% (13) 13 / 213 runs
flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
6.64% (14) 14 / 211 runs
failed over last 7 days
21.33% (45) 45 / 211 runs
flaked over last 7 days

View Detailed Build Results


private logger = new Logger("GcalService");

private gcalResponseSchema = z.object({ client_id: z.string(), client_secret: z.string() });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you changed the class to GCalService with a capital G, want to do the same here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants