-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Platform tidy up unused variables, etc #14289
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add platform team as reviewer" took an action on this PR • (04/02/24)1 reviewer was added to this PR based on Keith Williams's automation. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 301 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/02/2024 10:05:41pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 56dd511 Started: 04/02/2024 10:02:28pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
pro user -- future Time slots should be reserved when selected
Retry 2 • Retry 1 • Initial Attempt |
0.47% (1)1 / 213 runfailed over last 7 days |
8.45% (18)18 / 213 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Update Profile Newly added secondary email should show as Unverified
Retry 1 • Initial Attempt |
0% (0)0 / 213 runsfailed over last 7 days |
6.10% (13)13 / 213 runsflaked over last 7 days |
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
6.64% (14)14 / 211 runsfailed over last 7 days |
21.33% (45)45 / 211 runsflaked over last 7 days |
private logger = new Logger("GcalService"); | ||
|
||
private gcalResponseSchema = z.object({ client_id: z.string(), client_secret: z.string() }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you changed the class to GCalService with a capital G, want to do the same here?
Platform tidy up unused variables, etc