Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: org guard did not have user org profile + missing db read in selectedCalendarRepo #14303

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

Fixes api v2 org guard user did not have profile, and missing db read instand in selected calendars repository

@ThyMinimalDev ThyMinimalDev requested a review from a team April 3, 2024 06:56
@graphite-app graphite-app bot requested a review from a team April 3, 2024 06:57
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Apr 3, 2024
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 6:58am

@ThyMinimalDev ThyMinimalDev requested review from supalarry and removed request for a team April 3, 2024 06:58
Copy link

graphite-app bot commented Apr 3, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 3, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/03/2024 07:11:09am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 69ff752

Started: 04/03/2024 07:07:31am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0.57% (1) 1 / 174 run
failed over last 7 days
1.72% (3) 3 / 174 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.09% (2) 2 / 183 runs
failed over last 7 days
62.30% (114) 114 / 183 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-170.15% (-114) -114 / 67 runs
failed over last 7 days
170.15% (114) 114 / 67 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-172.31% (-112) -112 / 65 runs
failed over last 7 days
172.31% (112) 112 / 65 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can verify the newly added secondary email
Retry 1Initial Attempt
1.10% (2) 2 / 182 runs
failed over last 7 days
6.04% (11) 11 / 182 runs
flaked over last 7 days

View Detailed Build Results


@ThyMinimalDev ThyMinimalDev merged commit c3b1de4 into main Apr 3, 2024
39 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-org-guard branch April 3, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants