feat: update platform oauth client form #14542

ThyMinimalDev · 2024-04-12T00:26:03Z

What does this PR do?

Enable edit of oauth client for platform

github-actions · 2024-04-12T00:26:14Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-04-12T00:26:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Apr 12, 2024 10:13am
cal	⬜️ Ignored (Inspect)	Visit Preview	Apr 12, 2024 10:13am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Apr 12, 2024 10:13am
qa-not-in-use	⬜️ Ignored (Inspect)	Visit Preview	Apr 12, 2024 10:13am

graphite-app · 2024-04-12T00:30:12Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-04-12T00:40:09Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/organizations/platform/oauth-clients`	`263.96 KB`	492.29 KB	140.65% (🟡 +0.15%)
`/settings/organizations/platform/oauth-clients/create`	`264.05 KB`	492.37 KB	140.68% (🟡 +0.30%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2024-04-12T00:40:17Z

Current Playwright Test Results Summary

✅ 310 Passing - ⚠️ 17 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/12/2024 12:33:41pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5d252df

Started: 04/12/2024 12:29:10pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 2 • Retry 1 • Initial Attempt	4.89% (15) 15 / 307 runs failed over last 7 days	25.73% (79) 79 / 307 runs flaked over last 7 days
Login and logout tests -- future Login flow validations -- future Should warn when user does not exist Retry 1 • Initial Attempt	0.33% (1) 1 / 305 run failed over last 7 days	2.95% (9) 9 / 305 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members Retry 1 • Initial Attempt	9.60% (31) 31 / 323 runs failed over last 7 days	32.82% (106) 106 / 323 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization Retry 1 • Initial Attempt	2.52% (8) 8 / 318 runs failed over last 7 days	16.04% (51) 51 / 318 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can verify the newly added secondary email Retry 1 • Initial Attempt	0% (0) 0 / 311 runs failed over last 7 days	6.75% (21) 21 / 311 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 1 • Initial Attempt	2.84% (9) 9 / 317 runs failed over last 7 days	33.44% (106) 106 / 317 runs flaked over last 7 days

📄 apps/web/playwright/settings-admin.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Settings/admin tests -- future should render /settings/admin page Retry 1 • Initial Attempt	0.61% (2) 2 / 326 runs failed over last 7 days	4.29% (14) 14 / 326 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

`null`	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	0% (0) 0 / 315 runs failed over last 7 days	63.81% (201) 201 / 315 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-176.99% (-200) -200 / 113 runs failed over last 7 days	176.99% (200) 200 / 113 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-176.99% (-200) -200 / 113 runs failed over last 7 days	176.99% (200) 200 / 113 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-175.22% (-198) -198 / 113 runs failed over last 7 days	176.99% (200) 200 / 113 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-180.18% (-200) -200 / 111 runs failed over last 7 days	180.18% (200) 200 / 111 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-180.18% (-200) -200 / 111 runs failed over last 7 days	180.18% (200) 200 / 111 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-180.18% (-200) -200 / 111 runs failed over last 7 days	180.18% (200) 200 / 111 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-180.18% (-200) -200 / 111 runs failed over last 7 days	180.18% (200) 200 / 111 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 316 runs failed over last 7 days	39.87% (126) 126 / 316 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme Retry 1 • Initial Attempt	0.63% (2) 2 / 316 runs failed over last 7 days	52.85% (167) 167 / 316 runs flaked over last 7 days

View Detailed Build Results

emrysal · 2024-04-16T00:54:57Z

Also looks good to me, but wondering if the i18n of this file is OK - looks like it misses a lot of translations

feat: update platform oauth client form

e7e8d41

graphite-app bot requested a review from a team April 12, 2024 00:26

dosubot bot added api area: API, enterprise API, access token, OAuth core area: core, team members only platform Anything related to our platform plan ✨ feature New feature or request labels Apr 12, 2024

graphite-app bot requested a review from a team April 12, 2024 00:26

fixup! feat: update platform oauth client form

cddae0e

vercel bot deployed to Preview – ai April 12, 2024 00:30 View deployment

ThyMinimalDev removed the request for review from a team April 12, 2024 00:36

ThyMinimalDev assigned Ryukemeister Apr 12, 2024

ThyMinimalDev requested a review from Ryukemeister April 12, 2024 00:36

vercel bot deployed to Preview – api April 12, 2024 00:36 View deployment

vercel bot deployed to Preview – dev April 12, 2024 01:02 View deployment

Ryukemeister added 2 commits April 12, 2024 15:42

add tooltip to mention permissions cannot be modified

a2786e9

Merge branch 'main' into edit-oauth-clients-platform

5d252df

Ryukemeister approved these changes Apr 12, 2024

View reviewed changes

vercel bot deployed to Preview – api April 12, 2024 10:24 View deployment

vercel bot deployed to Preview – dev April 12, 2024 10:50 View deployment

keithwillcode added this to the v4.1 milestone Apr 15, 2024

emrysal merged commit 8e883a6 into main Apr 16, 2024
40 checks passed

emrysal deleted the edit-oauth-clients-platform branch April 16, 2024 00:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update platform oauth client form #14542

feat: update platform oauth client form #14542

ThyMinimalDev commented Apr 12, 2024

github-actions bot commented Apr 12, 2024 •

edited

Loading

vercel bot commented Apr 12, 2024 •

edited

Loading

graphite-app bot commented Apr 12, 2024

github-actions bot commented Apr 12, 2024 •

edited

Loading

deploysentinel bot commented Apr 12, 2024 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

emrysal commented Apr 16, 2024

feat: update platform oauth client form #14542

feat: update platform oauth client form #14542

Conversation

ThyMinimalDev commented Apr 12, 2024

What does this PR do?

github-actions bot commented Apr 12, 2024 • edited Loading

vercel bot commented Apr 12, 2024 • edited Loading

graphite-app bot commented Apr 12, 2024

Graphite Automations

github-actions bot commented Apr 12, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

Two Pages Changed Size

deploysentinel bot commented Apr 12, 2024 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

emrysal commented Apr 16, 2024

github-actions bot commented Apr 12, 2024 •

edited

Loading

vercel bot commented Apr 12, 2024 •

edited

Loading

github-actions bot commented Apr 12, 2024 •

edited

Loading

deploysentinel bot commented Apr 12, 2024 •

edited

Loading