Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API v2 recurring spelling #14620

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: API v2 recurring spelling #14620

merged 1 commit into from
Apr 16, 2024

Conversation

keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Apr 16, 2024

Fixes spelling of "recurring". It is currently "reccuring"

@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Apr 16, 2024
@keithwillcode keithwillcode added this to the v4.1 milestone Apr 16, 2024
@keithwillcode keithwillcode requested a review from a team April 16, 2024 21:31
@keithwillcode keithwillcode self-assigned this Apr 16, 2024
@graphite-app graphite-app bot requested a review from a team April 16, 2024 21:32
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth core area: core, team members only platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:33pm

@@ -10,6 +10,9 @@ export class RewriterMiddleware implements NestMiddleware {
if (req.url.startsWith("/v2/ee")) {
req.url = req.url.replace("/v2/ee", "/v2");
}
if (req.url.contains("reccuring")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are people already using reccuring?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible but probably nobody is since we didnt expose the hook to create recurring booking

Copy link

graphite-app bot commented Apr 16, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 16, 2024

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/16/2024 09:52:34pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 03293a0

Started: 04/16/2024 09:48:10pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 2Retry 1Initial Attempt
5.48% (17) 17 / 310 runs
failed over last 7 days
38.71% (120) 120 / 310 runs
flaked over last 7 days

📄   apps/web/playwright/eventType/limit-tab.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Limits Tab - Event Type Check the functionalities of the Limits Tab
Retry 1Initial Attempt
0% (0) 0 / 295 runs
failed over last 7 days
2.71% (8) 8 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity Can manage single schedule
Retry 1Initial Attempt
0.65% (2) 2 / 309 runs
failed over last 7 days
25.89% (80) 80 / 309 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Profile page is loaded for users in Organization
Retry 1Initial Attempt
0% (0) 0 / 303 runs
failed over last 7 days
0.66% (2) 2 / 303 runs
flaked over last 7 days
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
6.95% (21) 21 / 302 runs
failed over last 7 days
23.84% (72) 72 / 302 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.34% (1) 1 / 297 run
failed over last 7 days
37.04% (110) 110 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1Initial Attempt
0.96% (3) 3 / 313 runs
failed over last 7 days
2.24% (7) 7 / 313 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode merged commit ae64d7b into main Apr 16, 2024
39 of 40 checks passed
@keithwillcode keithwillcode deleted the fix/reccuring-spelling branch April 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only foundation High priority Created by Linear-GitHub Sync platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants