Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Impersonation flicker on timezone change #14738

Merged
merged 3 commits into from
May 14, 2024

Typescript definitions for playwright use are wrong

af3dcc1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: Impersonation flicker on timezone change #14738

Typescript definitions for playwright use are wrong
af3dcc1
Select commit
Loading
Failed to load commit list.
GitHub Actions / ESLint Report Analysis succeeded Apr 24, 2024 in 1s

ESLint Report Analysis

0 ESLint error(s) and 72 ESLint warning(s) found

Details

Annotations

Check warning on line 77 in apps/web/playwright/ab-tests-redirect.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/ab-tests-redirect.e2e.ts#L75-L77

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 30 in packages/app-store/_utils/useAddAppMutation.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/_utils/useAddAppMutation.ts#L30

[@typescript-eslint/no-unused-vars] 'useAddAppMutationVariables' is defined but never used. Allowed unused vars must match /^_/u.

Check warning on line 93 in apps/web/playwright/ab-tests-redirect.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/ab-tests-redirect.e2e.ts#L91-L93

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 25 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L25

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 109 in apps/web/playwright/ab-tests-redirect.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/ab-tests-redirect.e2e.ts#L107-L109

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 38 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L38

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 125 in apps/web/playwright/ab-tests-redirect.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/ab-tests-redirect.e2e.ts#L123-L125

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 41 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L41

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 13 in apps/web/playwright/app-store.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/app-store.e2e.ts#L13

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 42 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L42

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 351 in apps/web/playwright/organization/booking.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/organization/booking.e2e.ts#L349-L351

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 60 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L60

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 14 in apps/web/playwright/out-of-office.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/out-of-office.e2e.ts#L14

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 72 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L72

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 33 in apps/web/playwright/out-of-office.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/out-of-office.e2e.ts#L33

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 237 in apps/web/playwright/payment-apps.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/payment-apps.e2e.ts#L235-L237

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 77 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L77

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 283 in apps/web/playwright/payment-apps.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/payment-apps.e2e.ts#L281-L283

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 104 in packages/app-store/googlecalendar/tests/google-calendar.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/google-calendar.e2e.ts#L104

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 17 in apps/web/playwright/payment.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/payment.e2e.ts#L17

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 110 in packages/app-store/googlecalendar/tests/testUtils.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/googlecalendar/tests/testUtils.ts#L110

[@typescript-eslint/no-explicit-any] Unexpected any. Specify a different type.

Check warning on line 18 in apps/web/playwright/payment.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/payment.e2e.ts#L18

[playwright/no-skipped-test] Unexpected use of the `.skip()` annotation.

Check warning on line 11 in packages/app-store/jelly/lib/VideoApiAdapter.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/jelly/lib/VideoApiAdapter.ts#L11

[@typescript-eslint/no-unused-vars] 'event' is defined but never used. Allowed unused args must match /^_/u.

Check warning on line 391 in apps/web/playwright/profile.e2e.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

apps/web/playwright/profile.e2e.ts#L389-L391

[playwright/no-conditional-in-test] Avoid having conditionals in tests

Check warning on line 32 in packages/app-store/jelly/lib/VideoApiAdapter.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app-store/jelly/lib/VideoApiAdapter.ts#L32

[@typescript-eslint/no-unused-vars] 'event' is defined but never used. Allowed unused args must match /^_/u.