Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terms and conditions text #15027

Merged
merged 3 commits into from
May 16, 2024
Merged

fix: terms and conditions text #15027

merged 3 commits into from
May 16, 2024

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Before:-

Screenshot 2024-05-14 at 6 50 05 PM

After:-

Screenshot 2024-05-14 at 6 48 18 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@graphite-app graphite-app bot requested a review from a team May 14, 2024 13:20
Copy link
Contributor

github-actions bot commented May 14, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 14, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:26pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 2:26pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 2:26pm

@Udit-takkar Udit-takkar added this to the v4.1 milestone May 14, 2024
Copy link

graphite-app bot commented May 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented May 14, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 14, 2024

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/15/2024 02:38:53pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ffcbd5d

Started: 05/15/2024 02:34:18pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 5 Flakes

Top 1 Common Error Messages

null

5 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
1.57% (4) 4 / 254 runs
failed over last 7 days
25.98% (66) 66 / 254 runs
flaked over last 7 days
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 2Retry 1Initial Attempt
3.19% (8) 8 / 251 runs
failed over last 7 days
7.17% (18) 18 / 251 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1Initial Attempt
0.40% (1) 1 / 252 run
failed over last 7 days
5.95% (15) 15 / 252 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can add Cal video location and book with it
Retry 2Retry 1Initial Attempt
1.19% (3) 3 / 252 runs
failed over last 7 days
5.56% (14) 14 / 252 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
3.20% (8) 8 / 250 runs
failed over last 7 days
16.80% (42) 42 / 250 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 245 runs
failed over last 7 days
60.41% (148) 148 / 245 runs
flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0.41% (1) 1 / 245 run
failed over last 7 days
57.14% (140) 140 / 245 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
0.41% (1) 1 / 245 run
failed over last 7 days
57.55% (141) 141 / 245 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
57.20% (139) 139 / 243 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

null

9 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-1.21% (-3) -3 / 247 runs
failed over last 7 days
60.73% (150) 150 / 247 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-150% (-150) -150 / 100 runs
failed over last 7 days
150% (150) 150 / 100 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-148% (-148) -148 / 100 runs
failed over last 7 days
148% (148) 148 / 100 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-142% (-142) -142 / 100 runs
failed over last 7 days
144% (144) 144 / 100 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-146.94% (-144) -144 / 98 runs
failed over last 7 days
146.94% (144) 144 / 98 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-146.94% (-144) -144 / 98 runs
failed over last 7 days
146.94% (144) 144 / 98 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-146.94% (-144) -144 / 98 runs
failed over last 7 days
146.94% (144) 144 / 98 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-146.94% (-144) -144 / 98 runs
failed over last 7 days
146.94% (144) 144 / 98 runs
flaked over last 7 days
Popup Tests should open on clicking child element
Retry 1Initial Attempt
-145.36% (-141) -141 / 97 runs
failed over last 7 days
145.36% (141) 141 / 97 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
1.16% (3) 3 / 258 runs
failed over last 7 days
23.26% (60) 60 / 258 runs
flaked over last 7 days

📄   apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1Initial Attempt
0% (0) 0 / 248 runs
failed over last 7 days
50.40% (125) 125 / 248 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- future Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
5.76% (14) 14 / 243 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
5.88% (15) 15 / 255 runs
failed over last 7 days
27.84% (71) 71 / 255 runs
flaked over last 7 days

View Detailed Build Results


@sean-brydon sean-brydon merged commit 490540a into main May 16, 2024
41 checks passed
@sean-brydon sean-brydon deleted the fix/terms-and-condition branch May 16, 2024 13:54
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants