refactor: v2 origin check error message

[supalarry]

Example app fails because of incorrect origin error. The browser appends example app URL as the "origin" header, but it is not set as redirect uri in the OAuth client, so the requests fail.

Purpose of the PR is to improve error message in such case to be more helpful.

[github-actions]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview		May 21, 2024 2:08pm
cal	⬜️ Ignored (Inspect)	Visit Preview		May 21, 2024 2:08pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 21, 2024 2:08pm

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (05/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel]

Current Playwright Test Results Summary

✅ 6 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/21/2024 03:06:03pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a055787

Started: 05/21/2024 03:05:00pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace Retry 1 • Initial Attempt	0.43% (1) 1 / 232 run failed over last 7 days	61.64% (143) 143 / 232 runs flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload Retry 1 • Initial Attempt	0% (0) 0 / 232 runs failed over last 7 days	63.79% (148) 148 / 232 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace) Retry 1 • Initial Attempt	0% (0) 0 / 232 runs failed over last 7 days	64.66% (150) 150 / 232 runs flaked over last 7 days
Namespacing Different namespaces can have different init configs Retry 1 • Initial Attempt	0% (0) 0 / 231 runs failed over last 7 days	61.47% (142) 142 / 231 runs flaked over last 7 days

---

View Detailed Build Results

---

[p6l-richard]

This is definitely an improvement, nice!
I think it's fine to be helpful to the user with a very descriptive and information-rich error message, given that this part of the code is behind an auth check, so we've already validated the user's access rights (& therefore we trust the user and want to be as helpful as possible).

Right? @supalarry & @ThyMinimalDev

--

For posterity, this could be improved even further with e.g.:

• add a section https://cal.com/docs/platform/oauthclient to our docs with a breadcrumb sublink to /platform/oauthclient#redirecturis to explain (1) this required to make platform work in a browser environment (or certain requests will fail) & (2) why we're doing this check
• Add a /platform/errors section to our docs (possibly auto-generated from the nextjs app/swagger?)
• Update the error message to point to the docs