feat: Fix Proton Calendar with ICS #15454
Conversation
|
@sekaiking is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
github-actions
bot
added
booking-page
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
|
dosubot
bot
added
the
app-store
Graphite Automations"Add community label" took an action on this PR • (06/17/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
sekaiking
changed the title
|
Nice one! Good job! That should work! |
There was a problem hiding this comment.
Thanks for the PR @sekaiking 🙌! Approach looks good but I am not able to save the ics. Also maybe add a tooltip or note for the checkbox with short description of what it does, it would be really helpful for users
Recording.2024-07-09.163004.mp4
|
Amazing update here so far. ✨ |
|
Thanks for the review @Amit91848! |
That is perfect; I can see from the update you mentioned "read-only," which specifies the Proton Mail that supports read-only ICS URLs. Since you are sending to email, the Proton Mail will still send the calendar update and will appear on the Proton Calendar. Which I explained in detail here: #14300 (comment) |
There was a problem hiding this comment.
Thanks for the review @Amit91848! You can't save it because you used an email, you are supposed to use the ICS link like the placeholder. This is how you get in Proton but it's only available if you have a payed Proton subscription https://proton.me/support/share-calendar-via-link
Yeah my bad. I don't have proton paid plan so used it with google calendar ics. Works like a charm!
A small issue tho. Left a comment.
|
I've fixed the add button, used Alert component instead, and updated the note message: |
|
Let's gooo! Let's ship it! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
Well done. I can’t wait to use it daily with my Proton and to share it ! |
|
Same here! |
* feat: fix proton calendar with ics * ics-feed: add note & clarify checkbox * fix review --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Amit Sharma <74371312+Amit91848@users.noreply.github.com>
What does this PR do?
Adds an option to skip writing to calendar in the
ics-feedapp (#13337). This allows it to integrate with calendar services that can't be written to, like Proton Calendar./claim #14300
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?