Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auth on api-v2 with api-key #15455

Merged
merged 17 commits into from
Jun 19, 2024
Merged

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Jun 17, 2024

What does this PR do?

Enables api calls to api-v2 to use api-key as authentication token

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

yarn test api-auth.strategy.spec.ts

@graphite-app graphite-app bot requested a review from a team June 17, 2024 10:17
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 3:58pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 3:58pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 3:58pm

@ThyMinimalDev ThyMinimalDev marked this pull request as draft June 17, 2024 10:18
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jun 17, 2024
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in labels Jun 17, 2024
Copy link

graphite-app bot commented Jun 17, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (06/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (06/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@ThyMinimalDev
Copy link
Contributor Author

e2e and self review coming soon

supalarry
supalarry previously approved these changes Jun 19, 2024
@ThyMinimalDev
Copy link
Contributor Author

Ready for merge

@ThyMinimalDev ThyMinimalDev added this pull request to the merge queue Jun 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2024
@ThyMinimalDev ThyMinimalDev added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 9a473d5 Jun 19, 2024
23 checks passed
@ThyMinimalDev ThyMinimalDev deleted the chore-apiv2-auth-api-key branch June 19, 2024 16:14
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* chore: enable apiv2 auth with api keys

* chore: enable apiv2 auth with api keys

* chore: enable apiv2 auth with api keys

* chore: enable apiv2 auth with api keys

* chore: enable apiv2 auth with api keys

* fixup! chore: enable apiv2 auth with api keys

* fixup! Merge branch 'chore-apiv2-auth-api-key' of github.com:calcom/cal.com into chore-apiv2-auth-api-key

* fixup! fixup! Merge branch 'chore-apiv2-auth-api-key' of github.com:calcom/cal.com into chore-apiv2-auth-api-key

* fixup! fixup! fixup! Merge branch 'chore-apiv2-auth-api-key' of github.com:calcom/cal.com into chore-apiv2-auth-api-key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants