Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CAL-3940] randomize Tip Sidebar #15469

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

jscafe-dev
Copy link
Contributor

@jscafe-dev jscafe-dev commented Jun 18, 2024

What does this PR do?

Fixes #15458

Used lodash shuffle to randomize "Tips Sidebar"

Loom Video: https://www.loom.com/share/6f839cc1435e4b5d8afb535b2ce34ad5?sid=26474013-c39e-4722-8511-9a20dc7e4148

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
    NO
  • What are the minimal test data to have?
    NA
  • What is expected (happy path) to have (input and output)?
    To see randomized Tips sidebar on each reload
  • Any other important info that could help to test that PR
  • No

Checklist

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 18, 2024
Copy link

vercel bot commented Jun 18, 2024

@jscafe-dev is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team June 18, 2024 03:55
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CAL-3940] randomize Tip Sidebar". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jun 18, 2024
@jscafe-dev jscafe-dev changed the title [CAL-3940] randomize Tip Sidebar fix: [CAL-3940] randomize Tip Sidebar Jun 18, 2024
Copy link

graphite-app bot commented Jun 18, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/18/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added this to the Community Only milestone Jun 18, 2024
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jun 20, 2024
@jscafe-dev
Copy link
Contributor Author

@PeerRich All checks are green!

@jscafe-dev
Copy link
Contributor Author

@PeerRich quick reminder, if we can merge this PR?

@jscafe-dev
Copy link
Contributor Author

@PeerRich @joeauyeung @sean-brydon I do not have permission to merge.

@hariombalhara hariombalhara added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2024
@jscafe-dev
Copy link
Contributor Author

@hariombalhara this PR got removed from the Merge queue due to some mysterious reasons.

@hariombalhara hariombalhara added this pull request to the merge queue Jun 21, 2024
Merged via the queue into calcom:main with commit c7a96e1 Jun 21, 2024
16 of 23 checks passed
@PeerRich PeerRich mentioned this pull request Jun 21, 2024
3 tasks
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3940] randomize "Tip Sidebar"
3 participants