Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create instant meeting error if DAILY_SCALE_PLAN is false #15508

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Jun 20, 2024

What does this PR do?

https://www.loom.com/share/ef70f71cac194bd7821763eae1f8969c?sid=d0595c32-fe03-4908-8097-76a2b0debbef

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Make sure DAILY_SCALE_PLAN in .env file is not set to true.
  • Try to create an instant meeting.
  • Notice that an Instant Meeting is successfully booked.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 20, 2024
@graphite-app graphite-app bot requested a review from a team June 20, 2024 10:19
Copy link

vercel bot commented Jun 20, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 🐛 bug Something isn't working label Jun 20, 2024
Copy link

graphite-app bot commented Jun 20, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added this to the v4.4 milestone Jun 20, 2024
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! But need approval from @Udit-takkar

@PeerRich PeerRich added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work Low priority Created by Linear-GitHub Sync labels Jun 21, 2024
@Udit-takkar Udit-takkar added this pull request to the merge queue Jun 21, 2024
Merged via the queue into calcom:main with commit c9a9f70 Jun 21, 2024
15 of 22 checks passed
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
…m#15508)

* fix: create instant meeting error due to enable_recording

* fix: check scale plan

---------

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Co-authored-by: Udit Takkar <udit222001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while creating Instant Meeting
5 participants