Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apple calendar connect atom #15510

Merged
merged 42 commits into from
Jun 27, 2024
Merged

feat: apple calendar connect atom #15510

merged 42 commits into from
Jun 27, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Jun 20, 2024

What does this PR do?

  • Adds connect to apple calendar atom for apple calendar integration

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

This can be tested in the examples app under packages/platform/examples/base. The steps to run examples app are as follows:

  1. Go to packages/platform/atoms and run yarn dev
  2. Go to apps/api/v2 and run yarn dev
  3. Go to packages/platform/examples/base and run yarn prisma db push and after that run yarn dev

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Ryukemeister
✅ ThyMinimalDev
❌ Rajiv Sahal


Rajiv Sahal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jun 20, 2024
Rajiv Sahal added 2 commits June 20, 2024 16:45
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:29pm
cal ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:29pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:29pm

@ThyMinimalDev ThyMinimalDev added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 416.68 KB 644.38 KB 184.11% (🟡 +0.15%)
/[user]/[type]/embed 416.68 KB 644.38 KB 184.11% (🟡 +0.15%)
/apps/[slug]/[...pages] 593.37 KB 821.07 KB 234.59% (🟡 +0.21%)
/auth/saml-idp 12.22 KB 239.92 KB 68.55% (🟢 -20.80%)
/d/[link]/[slug] 416.48 KB 644.18 KB 184.05% (🟡 +0.15%)
/event-types 566.4 KB 794.09 KB 226.88% (🟡 +0.30%)
/event-types/[type] 442.05 KB 669.75 KB 191.36% (🟡 +0.15%)
/org/[orgSlug]/[user]/[type] 416.88 KB 644.58 KB 184.16% (🟡 +0.15%)
/org/[orgSlug]/[user]/[type]/embed 416.9 KB 644.6 KB 184.17% (🟡 +0.15%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 416.5 KB 644.2 KB 184.06% (🟡 +0.14%)
/org/[orgSlug]/team/[slug]/[type] 416.69 KB 644.39 KB 184.11% (🟡 +0.15%)
/settings/admin/lockedSMS/UsersTable 79.91 KB 307.61 KB 87.89% (🟢 -0.16%)
/settings/admin/lockedSMS/lockedSMSView 119.39 KB 347.09 KB 99.17% (🟢 -0.19%)
/settings/admin/oAuth/oAuthView 95.44 KB 323.14 KB 92.33% (🟢 -0.19%)
/settings/organizations/[id]/about 159.6 KB 387.3 KB 110.66% (🟡 +0.45%)
/settings/organizations/[id]/add-teams 159.59 KB 387.29 KB 110.65% (🟡 +0.46%)
/settings/organizations/new 159.6 KB 387.3 KB 110.66% (🟡 +0.45%)
/settings/platform/new 120.65 KB 348.34 KB 99.53% (🟡 +0.50%)
/team/[slug]/[type] 416.66 KB 644.36 KB 184.10% (🟡 +0.15%)
/team/[slug]/[type]/embed 416.69 KB 644.39 KB 184.11% (🟡 +0.15%)
/video/[uid] 290.75 KB 518.44 KB 148.13% (🟢 -0.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@emrysal emrysal added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 5e382ff Jun 27, 2024
41 of 51 checks passed
@emrysal emrysal deleted the apple-calendar-connect-atom branch June 27, 2024 17:17
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* init apple calendar service

* update apple calendar service logic

* update typing for CalendarApp interface

* add id and type for apple calendar

* fixup: logic for apple calendar service

* update logic for checkIfCalendarConnected function

* add apple calendar service to calendars module

* fixup

* update calendars to include cases for apple calendar

* fix imports

* init frontend for apple calendar connect

* add apple connect atom to connect atom

* fixup

* fixup

* add alias for latest version of platform library

* fix import paths

* custom hook for saving apple calendar credentials

* add apple calendar to examples app

* add interface for credentials syncing calendars

* bring calendars controller to orginal state

* refactor

* update custom hook to sync credentials

* update atom

* resolve merge conflicts

* add endpoint for syncing calendar credentials

* fixup

* update atom

* update useCheck to invalidate queries onSubmit

* fix typo

* fixup

* remove unused tokens respository

* rename controller

* cleanup

* fix: reset react queryClient on access token change

---------

Co-authored-by: Rajiv Sahal <rajivsahal@Rajivs-MacBook-Pro.local>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Co-authored-by: Morgan Vernay <morgan@cal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants