Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update z-index for intercom app launcher #15516

Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix: update z-index for intercom app launcher #15516

merged 4 commits into from
Jun 27, 2024

Conversation

osamajandali
Copy link
Contributor

@osamajandali osamajandali commented Jun 21, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change
  • N/A -I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

This is a UI fix that should be tested by triggering a modal and make sure the modal overlap the intercom icon

@graphite-app graphite-app bot requested a review from a team June 21, 2024 01:07
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 21, 2024
Copy link

vercel bot commented Jun 21, 2024

@osamajandali is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jun 21, 2024
@dosubot dosubot bot added this to the Community Only milestone Jun 21, 2024
@dosubot dosubot bot added the 🐛 bug Something isn't working label Jun 21, 2024
Copy link

graphite-app bot commented Jun 21, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/21/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@ThyMinimalDev
Copy link
Contributor

Screenshot 2024-06-21 at 16 02 08 it seems this class already sets the highest possible z-index, in which browser is this issue happening ?

@skmanoj322
Copy link

@osamajandali i have tried to reproduce the error but not able to find intercom in dev but in production i am able to see that.
can you please tell how you reproduced?

@osamajandali
Copy link
Contributor Author

@ThyMinimalDev if you take a look into the issue Peer want it to be underneath the modal so people can hit Copy code button easily if there is an overlap happens

@skmanoj322 You need to add intercom app id in .env

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@emrysal emrysal added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@emrysal emrysal added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@emrysal emrysal added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@keithwillcode keithwillcode added this pull request to the merge queue Jun 27, 2024
Merged via the queue into calcom:main with commit a02747f Jun 27, 2024
26 of 33 checks passed
@osamajandali osamajandali deleted the fix/show_intercom_below_dialogs branch June 30, 2024 15:43
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3948] z-index: show intercom below dialogs
5 participants