Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Time blocks #16261

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

feat: Time blocks #16261

wants to merge 40 commits into from

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Aug 19, 2024

What does this PR do?

Please note that the time blocks currently only work for Google and Office-365 Calendars.

https://www.loom.com/share/135020a75791426a8958e6429e55e5fb?sid=75b9446c-73aa-4546-8f3a-855129bf2cb4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create event(s) in your calendar with a specific title, say "Roundtable".
  • Create a new schedule and add time blocks to that schedule.
  • Add the title of the calendar event(s) ("Roundtable") to the time blocks.
  • Choose this newly created schedule as the availability schedule for an event type.
  • Now visit the booking page for that event type
  • Notice that availability is only shown for the exact time of the event(s) in your calendar titled "Roundtable".

Copy link

vercel bot commented Aug 19, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Aug 19, 2024
@graphite-app graphite-app bot requested review from a team August 19, 2024 06:27
@github-actions github-actions bot added ❗️ migrations contains migration files linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Aug 19, 2024
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Aug 19, 2024
@dosubot dosubot bot added this to the v4.5 milestone Aug 19, 2024
Copy link

graphite-app bot commented Aug 19, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (08/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (08/19/24)

1 label was added to this PR based on Keith Williams's automation.

@kart1ka kart1ka marked this pull request as draft August 19, 2024 06:41
@kart1ka kart1ka marked this pull request as ready for review August 20, 2024 18:28
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design does not match:-

figma
Screenshot 2024-08-21 072023

This pr
Screenshot 2024-08-21 071831

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it make sense to provide a dropdown to choose the title is contains or equal to event name. I found this in the design also
Screenshot 2024-08-21 072556

@github-actions github-actions bot added the Stale label Oct 3, 2024
@github-actions github-actions bot removed the Stale label Oct 9, 2024
@dosubot dosubot bot modified the milestones: v4.6, v4.7 Oct 16, 2024
@kart1ka
Copy link
Contributor Author

kart1ka commented Nov 9, 2024

Hi @CarinaWolli
I have made the changes as per your suggestions.
I have also fixed the all day event bug with both google calendar and office-365 calendar.
Now the time blocks are in addition to the existing availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request high-risk Requires approval by Foundation team linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2962] Time blocks: Free up slots on schedule based on specific event in calendar
6 participants