V2 Main #3549
V2 Main #3549
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@sean-brydon very good job so far! JM2C, I think @PeerRich removed all shadows from everywhere to avoid those from now on and also @Jaibles asked to only use |
| import { HttpError } from "@lib/core/http/error"; | ||
|
|
||
| import { EmbedButton, EmbedDialog } from "@components/Embed"; | ||
| import EventTypeDescription from "@components/eventtype/EventTypeDescription"; |
There was a problem hiding this comment.
We don't use the v2 component for EventTypeDescription here. @sean-brydon is that on purpose?
| @@ -20,6 +20,10 @@ module.exports = { | |||
| * @see https://github.com/storybookjs/storybook/issues/12844#issuecomment-867544160 | |||
| */ | |||
| config.resolve.roots = [path.resolve(__dirname, "../public"), "node_modules"]; | |||
| config.resolve.alias = { | |||
| ...config.resolve.alias, | |||
| "@/interfaces": path.resolve(__dirname, "../interfaces"), | |||
| @@ -1,7 +1,7 @@ | |||
| import { ComponentMeta } from "@storybook/react"; | |||
| import { Bell } from "react-feather"; | |||
|
|
|||
| import { Badge } from "@calcom/ui/v2"; | |||
| @@ -1,7 +1,7 @@ | |||
| import { ComponentStory, ComponentMeta } from "@storybook/react"; | |||
There was a problem hiding this comment.
| import { ComponentStory, ComponentMeta } from "@storybook/react"; | |
| import { ComponentMeta } from "@storybook/react"; |
| @@ -1,6 +1,6 @@ | |||
| import { ComponentMeta } from "@storybook/react"; | |||
|
|
|||
| import { Breadcrumb, BreadcrumbItem } from "@calcom/ui/v2"; | |||
| import Breadcrumb, { BreadcrumbItem } from "@calcom/ui/v2/core/Breadcrumb"; | |||
|
|
|||
There was a problem hiding this comment.
Was the other approach causing issues? I think the former is the desirable way to consume these components. If they are causing issues we should figure out why.
| @@ -222,7 +222,11 @@ const getEmbedTypeSpecificString = ({ | |||
| if (!frameworkCodes) { | |||
| throw new Error(`No code available for the framework:${embedFramework}`); | |||
| } | |||
| let uiInstructionStringArg = undefined; | |||
| let uiInstructionStringArg: { | |||
| @@ -29,7 +29,7 @@ import { detectBrowserTimeFormat } from "@calcom/lib/timeFormat"; | |||
| import { localStorage } from "@calcom/lib/webstorage"; | |||
| import { trpc } from "@calcom/trpc/react"; | |||
| import { Icon } from "@calcom/ui/Icon"; | |||
| import DatePicker from "@calcom/ui/booker/DatePicker"; | |||
| import DatePicker from "@calcom/ui/v2/modules/booker/DatePicker"; | |||
There was a problem hiding this comment.
Do we want to modify v1 AvailabilityPage in this PR? Would it make sense to take the duplicate v2 approach in here as well?
| import Swatch from "@calcom/ui/v2/Swatch"; | ||
| import { Swatch } from "@calcom/ui/v2"; |
There was a problem hiding this comment.
This is how we should be consuming components IMO.
| import React, { FC } from "react"; | ||
| import { Controller, SubmitHandler, useForm, useWatch } from "react-hook-form"; | ||
|
|
||
| import { Button, Select, TextArea, TextField } from "@calcom/ui/v2"; |
There was a problem hiding this comment.
| import { Button, Select, TextArea, TextField } from "@calcom/ui/v2"; | |
| import { Button, Select, TextField } from "@calcom/ui/v2"; |
| @@ -0,0 +1,322 @@ | |||
| import autoAnimate from "@formkit/auto-animate"; | |||
| import { EventTypeCustomInput, EventTypeCustomInputType } from "@prisma/client/"; | |||
There was a problem hiding this comment.
| import { EventTypeCustomInput, EventTypeCustomInputType } from "@prisma/client/"; | |
| import { EventTypeCustomInput } from "@prisma/client"; |
|
Merging as we need to test this on staging ASAP |
V2. WIP