-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 for app setup pages #4086
V2 for app setup pages #4086
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @zomars we wanna get rid of Loaders in favour of Skeletons, right?
<div className="absolute z-50 flex h-screen w-full items-center bg-gray-200"> | ||
<Loader /> | ||
</div> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we wanna use skeletons in the future for everything, no? @zomars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @PeerRich but in this context I don't see the benefit of using skeletons
It's just a blank setup page
What does this PR do?
Adds V2 pages with v2 components for all app setup pages.
Fixes 'App setup pages are still in old design and redirect not working in V2' of #4009