Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 for app setup pages #4086

Merged
merged 4 commits into from
Sep 2, 2022
Merged

V2 for app setup pages #4086

merged 4 commits into from
Sep 2, 2022

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Adds V2 pages with v2 components for all app setup pages.

Fixes 'App setup pages are still in old design and redirect not working in V2' of #4009

@vercel
Copy link

vercel bot commented Sep 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 7:59PM (UTC)

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @zomars we wanna get rid of Loaders in favour of Skeletons, right?

Comment on lines +16 to +19
<div className="absolute z-50 flex h-screen w-full items-center bg-gray-200">
<Loader />
</div>
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we wanna use skeletons in the future for everything, no? @zomars

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @PeerRich but in this context I don't see the benefit of using skeletons

It's just a blank setup page

image

@zomars zomars merged commit 46f2142 into main Sep 2, 2022
@zomars zomars deleted the feat/v2-app-setup-pages branch September 2, 2022 20:39
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants