Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added better regex for whereby allowing subdomains #7957

Merged
merged 4 commits into from Mar 27, 2023

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Mar 27, 2023

whereby has added subdomains which we need to add to the regex

TODO

  • test (only tested inside regexr)

CleanShot 2023-03-27 at 18 40 07@2x

@PeerRich PeerRich requested a review from a team March 27, 2023 16:40
@PeerRich PeerRich linked an issue Mar 27, 2023 that may be closed by this pull request
@linear
Copy link

linear bot commented Mar 27, 2023

CAL-1330 Whereby support subdomains

support subdomains in verification regex

@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Mar 27, 2023 at 7:02PM (UTC)
dhe ❌ Failed (Inspect) Mar 27, 2023 at 7:02PM (UTC)
ui ❌ Failed (Inspect) Mar 27, 2023 at 7:02PM (UTC)

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.22 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user] 103.39 KB 336.61 KB 96.17% (🟡 +0.02%)
/[user]/[type] 91.85 KB 325.06 KB 92.88% (🟡 +0.01%)
/[user]/[type]/embed 91.87 KB 325.09 KB 92.88% (🟡 +0.02%)
/[user]/book 183.4 KB 416.61 KB 119.03% (🟡 +0.02%)
/[user]/embed 103.46 KB 336.67 KB 96.19% (🟡 +0.02%)
/apps 167.11 KB 400.33 KB 114.38% (🟡 +0.02%)
/apps/[slug] 190.84 KB 424.05 KB 121.16% (🟡 +0.01%)
/apps/[slug]/[...pages] 392.26 KB 625.47 KB 178.71% (🟡 +0.01%)
/apps/categories 152.01 KB 385.23 KB 110.07% (🟡 +0.01%)
/apps/categories/[category] 155.88 KB 389.09 KB 111.17% (🟡 +0.01%)
/apps/installed/[category] 196.98 KB 430.2 KB 122.91% (🟡 +0.02%)
/availability 155.22 KB 388.44 KB 110.98% (🟡 +0.02%)
/availability/[schedule] 272.02 KB 505.24 KB 144.35% (🟡 +0.02%)
/availability/troubleshoot 152.7 KB 385.92 KB 110.26% (🟡 +0.02%)
/booking/[uid] 123.51 KB 356.73 KB 101.92% (🟡 +0.02%)
/bookings/[status] 272.33 KB 505.54 KB 144.44% (🟡 +0.02%)
/d/[link]/[slug] 91.49 KB 324.71 KB 92.77% (🟡 +0.02%)
/d/[link]/[slug]/embed 91.52 KB 324.74 KB 92.78% (🟡 +0.02%)
/d/[link]/book 183.05 KB 416.27 KB 118.93% (🟡 +0.02%)
/event-types 349.26 KB 582.47 KB 166.42% (🟡 +0.02%)
/event-types/[type] 382.31 KB 615.53 KB 175.86% (🟡 +0.02%)
/insights 386.18 KB 619.4 KB 176.97% (🟡 +0.02%)
/more 151.64 KB 384.85 KB 109.96% (🟡 +0.01%)
/payment/[uid] 60.8 KB 294.01 KB 84.00% (🟡 +0.02%)
/settings/admin 157.09 KB 390.31 KB 111.52% (🟡 +0.01%)
/settings/admin/apps 165.78 KB 399 KB 114.00% (🟡 +0.01%)
/settings/admin/apps/[category] 165.76 KB 398.98 KB 113.99% (🟡 +0.02%)
/settings/admin/flags 159.99 KB 393.2 KB 112.34% (🟡 +0.02%)
/settings/admin/impersonation 157.38 KB 390.59 KB 111.60% (🟡 +0.01%)
/settings/billing 157.21 KB 390.42 KB 111.55% (🟡 +0.01%)
/settings/developer/api-keys 186.36 KB 419.58 KB 119.88% (🟡 +0.01%)
/settings/developer/webhooks 159.7 KB 392.91 KB 112.26% (🟡 +0.02%)
/settings/developer/webhooks/[id] 190.55 KB 423.76 KB 121.08% (🟡 +0.01%)
/settings/developer/webhooks/new 190.41 KB 423.63 KB 121.04% (🟡 +0.01%)
/settings/my-account/appearance 171.17 KB 404.39 KB 115.54% (🟡 +0.01%)
/settings/my-account/calendars 191.39 KB 424.61 KB 121.32% (🟡 +0.01%)
/settings/my-account/conferencing 162.97 KB 396.18 KB 113.20% (🟡 +0.01%)
/settings/my-account/general 266.36 KB 499.58 KB 142.74% (🟡 +0.01%)
/settings/my-account/profile 274.25 KB 507.47 KB 144.99% (🟡 +0.02%)
/settings/security/impersonation 159.25 KB 392.46 KB 112.13% (🟡 +0.02%)
/settings/security/password 192.54 KB 425.76 KB 121.64% (🟡 +0.02%)
/settings/security/sso 166.94 KB 400.16 KB 114.33% (🟡 +0.02%)
/settings/security/two-factor-auth 161.7 KB 394.92 KB 112.83% (🟡 +0.02%)
/settings/teams 156.84 KB 390.06 KB 111.44% (🟡 +0.02%)
/settings/teams/[id]/appearance 171.19 KB 404.41 KB 115.55% (🟡 +0.01%)
/settings/teams/[id]/billing 157.07 KB 390.29 KB 111.51% (🟡 +0.02%)
/settings/teams/[id]/members 297.08 KB 530.29 KB 151.51% (🟡 +0.02%)
/settings/teams/[id]/profile 269.46 KB 502.68 KB 143.62% (🟡 +0.02%)
/settings/teams/[id]/sso 167.03 KB 400.25 KB 114.36% (🟡 +0.01%)
/settings/teams/new 92.67 KB 325.89 KB 93.11% (+/- <0.01%)
/team/[slug]/[type] 91.5 KB 324.71 KB 92.78% (🟡 +0.01%)
/team/[slug]/[type]/embed 91.53 KB 324.74 KB 92.78% (🟡 +0.02%)
/team/[slug]/book 183.05 KB 416.27 KB 118.93% (🟡 +0.02%)
/teams 151.86 KB 385.07 KB 110.02% (🟡 +0.02%)
/workflows 164.75 KB 397.97 KB 113.71% (🟡 +0.01%)
/workflows/[workflow] 293.95 KB 527.16 KB 150.62% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Co-authored-by: Alex van Andel <me@alexvanandel.com>
@emrysal emrysal merged commit 08ad4c0 into main Mar 27, 2023
6 of 10 checks passed
@emrysal emrysal deleted the 7927-cal-1330-whereby-support-subdomains branch March 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1330] Whereby support subdomains
2 participants