Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misaligned booking frequency toggle #8006

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

GermaVinsmoke
Copy link
Contributor

What does this PR do?

Fixes #7954

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to Event types page
  • Edit any event and select Limits
  • Turn on limit booking frequency

Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
@GermaVinsmoke GermaVinsmoke requested a review from a team March 29, 2023 11:11
@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 3:36AM (UTC)

@vercel
Copy link

vercel bot commented Mar 29, 2023

@GermaVinsmoke is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Sixty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.45 KB 241.78 KB 69.08% (+/- <0.01%)
/[user] 70.21 KB 303.54 KB 86.72% (+/- <0.01%)
/[user]/[type] 91.94 KB 325.28 KB 92.94% (+/- <0.01%)
/[user]/[type]/embed 91.97 KB 325.3 KB 92.94% (+/- <0.01%)
/[user]/embed 70.27 KB 303.6 KB 86.74% (+/- <0.01%)
/apps 167.17 KB 400.5 KB 114.43% (+/- <0.01%)
/apps/[slug] 190.89 KB 424.22 KB 121.21% (+/- <0.01%)
/apps/[slug]/[...pages] 392.29 KB 625.63 KB 178.75% (+/- <0.01%)
/apps/categories 152.07 KB 385.4 KB 110.11% (+/- <0.01%)
/apps/categories/[category] 155.93 KB 389.27 KB 111.22% (+/- <0.01%)
/apps/installed/[category] 197.09 KB 430.42 KB 122.98% (+/- <0.01%)
/auth/error 19.24 KB 252.57 KB 72.16% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.96 KB 73.99% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.16 KB 76.05% (+/- <0.01%)
/auth/login 40.1 KB 273.43 KB 78.12% (+/- <0.01%)
/auth/logout 7.56 KB 240.89 KB 68.83% (+/- <0.01%)
/availability 155.38 KB 388.71 KB 111.06% (+/- <0.01%)
/availability/[schedule] 272.13 KB 505.46 KB 144.42% (+/- <0.01%)
/availability/troubleshoot 152.76 KB 386.09 KB 110.31% (+/- <0.01%)
/booking/[uid] 123.62 KB 356.95 KB 101.99% (+/- <0.01%)
/bookings/[status] 272.46 KB 505.79 KB 144.51% (+/- <0.01%)
/d/[link]/[slug] 91.59 KB 324.92 KB 92.83% (+/- <0.01%)
/d/[link]/[slug]/embed 91.62 KB 324.95 KB 92.84% (+/- <0.01%)
/event-types/[type] 383.08 KB 616.41 KB 176.12% (+/- <0.01%)
/insights 387.22 KB 620.55 KB 177.30% (+/- <0.01%)
/more 151.69 KB 385.02 KB 110.01% (+/- <0.01%)
/settings/admin 157.15 KB 390.48 KB 111.57% (+/- <0.01%)
/settings/admin/apps 165.83 KB 399.17 KB 114.05% (+/- <0.01%)
/settings/admin/apps/[category] 165.82 KB 399.15 KB 114.04% (+/- <0.01%)
/settings/admin/flags 160.04 KB 393.37 KB 112.39% (+/- <0.01%)
/settings/admin/impersonation 157.43 KB 390.76 KB 111.65% (+/- <0.01%)
/settings/billing 157.26 KB 390.59 KB 111.60% (+/- <0.01%)
/settings/developer/api-keys 186.42 KB 419.75 KB 119.93% (+/- <0.01%)
/settings/developer/webhooks 159.92 KB 393.25 KB 112.36% (+/- <0.01%)
/settings/developer/webhooks/[id] 190.61 KB 423.94 KB 121.13% (🟢 -0.01%)
/settings/developer/webhooks/new 190.46 KB 423.8 KB 121.08% (+/- <0.01%)
/settings/my-account/appearance 171.22 KB 404.56 KB 115.59% (+/- <0.01%)
/settings/my-account/calendars 191.45 KB 424.78 KB 121.37% (+/- <0.01%)
/settings/my-account/conferencing 163.07 KB 396.4 KB 113.26% (+/- <0.01%)
/settings/my-account/general 266.42 KB 499.75 KB 142.78% (+/- <0.01%)
/settings/my-account/profile 274.24 KB 507.57 KB 145.02% (+/- <0.01%)
/settings/security/password 192.59 KB 425.93 KB 121.69% (+/- <0.01%)
/settings/security/sso 167 KB 400.33 KB 114.38% (+/- <0.01%)
/settings/security/two-factor-auth 161.75 KB 395.09 KB 112.88% (+/- <0.01%)
/settings/teams 156.89 KB 390.23 KB 111.49% (+/- <0.01%)
/settings/teams/[id]/appearance 171.25 KB 404.58 KB 115.59% (+/- <0.01%)
/settings/teams/[id]/billing 157.13 KB 390.46 KB 111.56% (+/- <0.01%)
/settings/teams/[id]/members 297.13 KB 530.46 KB 151.56% (+/- <0.01%)
/settings/teams/[id]/profile 269.45 KB 502.78 KB 143.65% (+/- <0.01%)
/settings/teams/[id]/sso 167.09 KB 400.42 KB 114.41% (+/- <0.01%)
/signup 25.5 KB 258.83 KB 73.95% (+/- <0.01%)
/team/[slug] 72.62 KB 305.95 KB 87.41% (+/- <0.01%)
/team/[slug]/[type] 91.59 KB 324.93 KB 92.84% (+/- <0.01%)
/team/[slug]/[type]/embed 91.63 KB 324.96 KB 92.84% (+/- <0.01%)
/team/[slug]/embed 72.68 KB 306.01 KB 87.43% (+/- <0.01%)
/teams 151.91 KB 385.24 KB 110.07% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 248 KB 70.86% (+/- <0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.63 KB 70.75% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.93 KB 68.55% (+/- <0.01%)
/workflows 164.81 KB 398.14 KB 113.75% (+/- <0.01%)
/workflows/[workflow] 294.02 KB 527.35 KB 150.67% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-03-30 at 2 13 47 PM

LGTM

@PeerRich PeerRich merged commit a72f90f into calcom:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1345] Misaligned Booking Frequency toggle
3 participants