Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catch emails sent locally using Mailhog #8470

Merged
merged 7 commits into from
May 6, 2023
Merged

feat: catch emails sent locally using Mailhog #8470

merged 7 commits into from
May 6, 2023
+25 −4

Conversation

Jonathan1599
Copy link
Contributor

@Jonathan1599 Jonathan1599 commented Apr 23, 2023 •
edited
Loading

What does this PR do?

Enables devs to catch emails using Mailhog.
Code changes:

  • Created a docker-compose.yml file in packages/emails for Mailhog.
  • Created a script (yarn dx) in packages/emails/package.json to bring up Mailhog.
  • Updated .env.example to work with Mailhog.
  • Included step to install Mailhog manually in README.MD .

Fixes #8199

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

@Jonathan1599 Jonathan1599 requested a review from a team April 23, 2023 12:38
@vercel
Copy link

vercel bot commented Apr 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:57pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:57pm

@vercel
Copy link

vercel bot commented Apr 23, 2023

@Jonathan1599 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Apr 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Jonathan1599 Jonathan1599 changed the title feat: added mailhog to catch emails sent locally feat: catch emails sent locally using Mailhog Apr 23, 2023
Udit-takkar
Udit-takkar reviewed Apr 28, 2023
View reviewed changes
.env.example Outdated Show resolved Hide resolved
Udit-takkar
Udit-takkar reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-28 at 4 13 56 PM

Works fine locally 👍

Udit-takkar
Udit-takkar approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@PeerRich
Copy link
Member

PeerRich commented May 5, 2023

waiting for @keithwillcode to approve and merge. LGTM on my end

keithwillcode
keithwillcode approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution. Thank you!

@keithwillcode keithwillcode merged commit 3c46c39 into calcom:main May 6, 2023
@p6l-richard p6l-richard mentioned this pull request May 11, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

@Udit-takkar Udit-takkar Udit-takkar approved these changes

@zomars zomars Awaiting requested review from zomars

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

Assignees
No one assigned
Labels
❗️ .env changes contains changes to env variables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-1460] Add mail catching service for local development
4 participants
@Jonathan1599 @PeerRich @keithwillcode @Udit-takkar