-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements: Prefill Routing Forms and connect prefilling with Booking Form #8780
Merged
hariombalhara
merged 7 commits into
main
from
improvements/prefill-support-routing-forms
May 17, 2023
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c235b00
Support prefilling routing form and prefilling Booking form through r…
hariombalhara 21319da
Use Option Value as is instead of lowercasing
hariombalhara 45fb94c
Fix prefill validation issue
hariombalhara 10fa353
Add prefill tests
hariombalhara 1221dd8
Fix Routing Form tests
hariombalhara c58717c
Merge remote-tracking branch 'origin/main' into improvements/prefill-…
hariombalhara 39c83d9
Small fix
hariombalhara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,7 +201,7 @@ export const FormBuilder = function FormBuilder({ | |
// It has the same drawback that if the label is changed, the value of the option will change. It is not a big deal for now. | ||
value.splice(index, 1, { | ||
label: e.target.value, | ||
value: e.target.value.toLowerCase().trim(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Routing Form uses the strategy of not lowercasing the option label and using it as is. |
||
value: e.target.value.trim(), | ||
}); | ||
onChange(value); | ||
}} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a controlled input so it should use value field.