-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile and env variables #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely compiles and works now. Got it running on localhost and on the web. Thanks for the great work!
I have a few notes in my review.
Google calendar and zoom integrations work.
What should I do to test? Should I use the regular With that still getting the "accept our license banner" and no integrations, and when changing the script to
|
Testers needed!
This PR updates the dockerfile and should run properly with a static site configuration (running
yarn start
instead of theyarn dev
workaround)Create a .env file by copying and renaming .env.example then substituting your variables. BASE_URL and NEXT_PUBLIC_APP_URL need to be set at build time. Use
docker-compose build
to accept those env variables automatically, or pass in the env variables manually usingdocker build
args.API-related variables (like the google API key) should work at runtime.
closes #50
closes #46
closes #45
related to #43
Note: additional customization and dev experience features are expected for the future. this intentionally takes a small step forward