Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile and env variables #51

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Conversation

krumware
Copy link
Member

@krumware krumware commented Nov 19, 2021

Testers needed!

This PR updates the dockerfile and should run properly with a static site configuration (running yarn start instead of the yarn dev workaround)

Create a .env file by copying and renaming .env.example then substituting your variables. BASE_URL and NEXT_PUBLIC_APP_URL need to be set at build time. Use docker-compose build to accept those env variables automatically, or pass in the env variables manually using docker build args.

API-related variables (like the google API key) should work at runtime.

closes #50
closes #46
closes #45
related to #43

Note: additional customization and dev experience features are expected for the future. this intentionally takes a small step forward

Copy link

@JanBobolz JanBobolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely compiles and works now. Got it running on localhost and on the web. Thanks for the great work!

I have a few notes in my review.

Google calendar and zoom integrations work.

.env.example Outdated Show resolved Hide resolved
.env.example Show resolved Hide resolved
docker-compose.yaml Show resolved Hide resolved
@krumware krumware merged commit 67663d0 into calcom:main Nov 24, 2021
@krumware krumware deleted the docker-build-fixes branch November 24, 2021 17:01
@wivaku
Copy link

wivaku commented Dec 21, 2021

What should I do to test? Should I use the regular git clone --recursive https://github.com/calendso/docker.git calendso-docker?

With that still getting the "accept our license banner" and no integrations, and when changing the script to yarn dev the app fails to start, with message in the log:

calendso         | Error: > Couldn't find a `pages` directory. Please create one under the project root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants