Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow github action to work on external repos #259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethanneff
Copy link

👋🏻 Hi there!

This template will help you describe the work you’ve done, so one of the project owners can review and potentially accept it promptly. Please fill relevant sections below and feel free to delete what does not apply to your work (including this comment).

Thank you for helping us improve Image Actions! ⚡️


What does this PR introduce?

In a few bullet points, please describe the changes this Pull Request makes. E.g.:

  • adds AVIF support
  • fixes #
  • updates README.md with a better description for contributions

Related issues

Are there any related issues or feature requests this work will resolve? Please mention them here. E.g.:

  • closes #

Learn more about linking Pull Requests to issues here.

Screenshots

If this work introduces any visual changes, add screenshots to portray them.

before (skipped workflow) | after (works)
Screenshot 24

Reviewers

Mention one or more project owners here or request review directly in the right sidebar in the Reviewers section:

@ethanneff ethanneff requested a review from thefoxis as a code owner May 20, 2024 16:55
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@benschwarz
Copy link
Member

Hey @ethanneff, thanks for the PR. Could you please sign the CLA and write a description of your changes and the motivations behind them?

At the moment the configuration you've changed is there purposefully to not optimize images on forked repositories. It would be good to hear why you think this behavior should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants