Implement static factory inheritance #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While factories declared at runtime -after a trytond transaction and pool have been setup- could be inherited, factories declared at module import time couldn't because of the base factory options assumptions. Hack the _get_counter_reference method to work with trytond models. Also improve the get_model_class so that inherited classes don't need to repeat the meta model.
maltalk
approved these changes
Sep 23, 2020
JMSoler7
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While factories declared at runtime -after a trytond
transaction and pool have been setup- could be inherited,
factories declared at module import time couldn't
because of the base factory options assumptions.
Hack the _get_counter_reference method to work with
trytond models.
Also improve the get_model_class so that inherited
classes don't need to repeat the meta model.