-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download of EEZ to happen on local (login) node #141
Fix download of EEZ to happen on local (login) node #141
Conversation
Fixes an issue introduced in calliope-project#99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this has never been a problem for me. Do you get errors when using job nodes for downloads or is this just your preference? I just wonder whether it's a good design choice to have downloads on the login node. Parallelising them would speed things up.
Yes, this fails in my setup as compute nodes have no internet access. I believe you said once it's possible to change that, but I'd rather not if not necessary. It's true that downloads on compute nodes could be faster as they could be parallelised. But you can also parallelise downloads on the login node using In any case, all download rules right now are local. So we should be consistent either way. |
@@ -14,6 +14,7 @@ SCHEMA_UNITS = { | |||
|
|||
configfile: "config/default.yaml" | |||
localrules: download_raw_gadm_administrative_borders, raw_gadm_administrative_borders, download_raw_nuts_units | |||
localrules: download_eez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is on a new line? I would find it easier to understand if the first line were to become a multi-line listing of localrules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm the first line is too long. There may be other ways of splitting this into several lines with just a single localrules
call, but I am not exactly sure how.
OK, would be good to think of a section in the documentation on how best to leverage snakemake args in Euro-Calliope (since their documentation is difficult to navigate, I find). Things like |
Good idea. I've opened issue #144 for that. |
…-eez-locally Fix download of EEZ to happen on local (login) node
Fixes an issue introduced in #99.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.