Eslint + Prettier = 😍 #19
Conversation
grabbou
force-pushed
the
feat/fix-linting
branch
from
0ef99d4
to
4072ad3
Compare
| @@ -53,7 +50,6 @@ function createServer( | |||
|
|
|||
| // Middlewares | |||
| appHandler | |||
| .use(morgan('tiny')) | |||
There was a problem hiding this comment.
@satya164 I think for that to work, we should probably expose a flag verbose on a command line tools in the future and later, use something more comprehensive?
There was a problem hiding this comment.
Let's remove this when we actually have it. Otherwise it's impossible to see if packager actually received the request. Though I think printing requests is pretty basic and shouldn't depend on --verbose
There was a problem hiding this comment.
Printing all requests like the above does should depend on verbose flag as informing about devtools ui request is not something average user would be interested in.
There was a problem hiding this comment.
Yes, I won't be interested in requests for devtools UI, but I'll certainly be interested in requests for the bundle and assets.
|
|
CC this issue to @mjackson when we open source that as he wanted me to do the same for react-router |
package.json
Outdated
| "lint": "eslint src", | ||
| "prettier": "prettier --single-quote --write src/**/*.js" | ||
| "precommit": "lint-staged", | ||
| "test": "flow && npm run lint", |
There was a problem hiding this comment.
I think flow should be a separate script. what if I just want to run flow?
| @@ -53,7 +50,6 @@ function createServer( | |||
|
|
|||
| // Middlewares | |||
| appHandler | |||
| .use(morgan('tiny')) | |||
There was a problem hiding this comment.
Let's remove this when we actually have it. Otherwise it's impossible to see if packager actually received the request. Though I think printing requests is pretty basic and shouldn't depend on --verbose
Place it after devTools middleware so that we dont log too much to end users, but request for assets only. Also, change url to path as we dont support params (like Packager) and printing them would make that confusing for people.
…i into feat/fix-linting
|
|
Fixes #17
In this PR:
global- I added it at the very beginning at the point I was hacking around trying to get things working.InitializeCorealready does that"). That caused it to not format nested files.eslint-config-prettierto turn off settings that either interfere with Prettier (--fix option) or warn about things prettier changes for us anyway (like trailing commas)precommitscript with Husky to run every time we commit - it automatically fixes small eslint issues for you, runs prettier and adds files to existing commitpackage.jsonto reduce dot files (I hate them)