feat: refactor plugins #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 8, 2020
thymikee
reviewed
Jul 8, 2020
| ? `${this.bundles.map( | ||
| bundleName => | ||
| `if (!this["${bundleName}"]) { this.bundleRegistryLoad("${bundleName}", true, true); }\n` | ||
| )}\n` |
There was a problem hiding this comment.
if we have dedent in deps somewhere, then it could be used to make it easier to read the template, but that's just a suggestion
thymikee
reviewed
Jul 8, 2020
packages/haul-core/src/webpack/plugins/PreloadModulesDllPlugin.ts
Outdated
Show resolved
Hide resolved
thymikee
reviewed
Jul 8, 2020
| }) | ||
| ); | ||
|
|
||
| minifyWorker.end(); |
There was a problem hiding this comment.
end() is now async: https://github.com/facebook/jest/blob/master/packages/jest-worker/src/index.ts#L140, make sure to check if the version you're on is async as well and if not, mark as todo or something
There was a problem hiding this comment.
I had a problem previosuly, when awaiting end() would never resolve and the whole process would hang indefinitely.
zamotany
force-pushed
the
feat/refactor-plugins
branch
from
40d32a4
to
0cf3c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor plugins to make them more descriptive of what they do, generic and reusable.