Skip to content

feat: add getByType helper #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2018
Merged

feat: add getByType helper #64

merged 2 commits into from
Nov 19, 2018

Conversation

thymikee
Copy link
Member

Summary

Adds new getByType, getAllByType render helper and query* equivalents to find components by type only. This is going to be the method where we'll point getByName when deprecation.

Test plan

Included.

@thymikee thymikee requested a review from Esemesek November 18, 2018 14:41
@thymikee
Copy link
Member Author

I'll add the docs when we'll mark getByName as deprecated in a followup PR.

Esemesek
Esemesek approved these changes Nov 19, 2018
View reviewed changes
Copy link
Collaborator

@Esemesek Esemesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but missing documentation.

@thymikee thymikee merged commit fa198c4 into master Nov 19, 2018
@thymikee thymikee deleted the feat/getByType branch November 19, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esemesek Esemesek Esemesek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thymikee @Esemesek