Add support for dbt-duckdb to the dbt_date package #105
Conversation
There was a problem hiding this comment.
Hi @jwills! Normally, I would have said let's do this in a shim package, but then you went ahead and added CI support making this very persuasive 😄
If we can the CI bit figured out, I think this should be good, but I'll give it a closer look then. Thanks for this!
.circleci/config.yml
Outdated
| name: "Run Tests - DuckDB" | ||
| command: | | ||
| . venv/bin/activate | ||
| dbt build -t duckdb --project_dir $DBT_PROJECT_DIR |
There was a problem hiding this comment.
Hmmm, somehow CI failed on this line https://app.circleci.com/pipelines/github/calogica/dbt-date/83/workflows/f4415d81-0620-43a2-93e1-f0303c64f2f9/jobs/58?invite=true#step-108-27
There was a problem hiding this comment.
A silly typo-- fixed!
|
okay, equally silly error b/c the integration tests are running an old version of dbt-duckdb (1.4.1) instead of the latest that I ran locally-- will fix shortly |
Looks like that did it! |
|
Would you mind also updating the README to note the support for duckdb? I will have probably have to release this is a 0.8.0 which also means a bump to the dbt-expectations version so might take a bit. |
Hello hello-- had some users testing out the new dbt semantic layer example with dbt-duckdb and we noticed some deltas between what DuckDB supports and the default macros that seemed worth fixing up; if you would prefer I do this via a shim package, please let me know! 🙇