Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macro test_expect_column_distinct_values_to_be_in_set returns false positive #33

Closed
Pegspeterson opened this issue Apr 7, 2021 · 2 comments · Fixed by #34
Closed

macro test_expect_column_distinct_values_to_be_in_set returns false positive #33

Pegspeterson opened this issue Apr 7, 2021 · 2 comments · Fixed by #34
Assignees
@clausherther
Labels
bug Something isn't working

Comments

@Pegspeterson
Copy link

I think that the final where clause in macro test_expect_column_distinct_values_to_be_in_set
should be
where
s.value_field is null

not
where
v.value_field is null
@clausherther clausherther self-assigned this Apr 8, 2021
@clausherther
Copy link
Contributor

Good eye @Pegspeterson, thanks for raising that issue. You're right, this line is wrong, will get that fixed!

@clausherther clausherther added the bug Something isn't working label Apr 8, 2021
clausherther added a commit that referenced this issue Apr 8, 2021
@clausherther
Fixes set logic, closes #33
6b0d84e
@clausherther clausherther mentioned this issue Apr 8, 2021
Merged
@Pegspeterson
Copy link
Author

Thank you for the quick fix! I was able to validate and it now fails as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clausherther clausherther

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes set logic in expect_column_distinct_values_to_be_in_set calogica/dbt-expectations
2 participants
@clausherther @Pegspeterson