Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux build: Main game window doesn't repair damage when Dialogue opened #208

Closed
clort81 opened this issue Jan 4, 2020 · 5 comments
Closed
Labels
bug linux Specific to Linux builds windows Specific to Windows builds

Comments

@clort81
Copy link

clort81 commented Jan 4, 2020

damage
The main game window doesn't repair damage (when stuff overwrites it) when Dialogue window is opened..

but it DOES... when map is invoked. Maybe we can invoke the dialogue window the same way map window is?

@CelticMinstrel CelticMinstrel added bug linux Specific to Linux builds windows Specific to Windows builds labels Jan 4, 2020
@CelticMinstrel
Copy link
Member

We can't make the dialog windows behave the same as the map window, because the map window is a modeless window while the dialogs are modal.

From what I recall (haven't tested recently), this is not a problem on the Mac. I think it's because the Mac doesn't dirty the canvas of covered windows (or something). Anyway I don't know how this can be fixed while keeping the windows modal... there must be a way, but I don't know what it is.

@NQNStudios
Copy link
Collaborator

I've just seen that this problem still affects the scenario editor--which makes sense, I was only trying to fix the game itself.

@CelticMinstrel
Copy link
Member

Presumably the same solution works in both editors though.

@NQNStudios
Copy link
Collaborator

NQNStudios commented Jan 5, 2023 via email

@NQNStudios
Copy link
Collaborator

We ended up determining that, due to SFML and operating system limitations, this can't be fixed further than it currently is by those PRs I made.

@NQNStudios NQNStudios closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linux Specific to Linux builds windows Specific to Windows builds
Projects
None yet
Development

No branches or pull requests

3 participants