Synchronize volume across player types #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calzoneman
added a commit
that referenced
this pull request
Jan 2, 2014
Synchronize volume across player types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature reads the volume level of the current player before transitioning to a new video, to prevent jarring changes in volume when the player changes e.g. from YouTube to Soundcloud. Furthermore, the volume is saved in
localStorageand persists.Known, unfixable issue with Soundcloud: Soundcloud's volume cannot be changed until playback begins. Because of this, it is possible that a short (< 1 second) clip might play at maximum volume before the volume is set. How they managed to screw this up is beyond me.