fixed: Allow touch Event that moves 10px. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathcheeno
reviewed
Aug 2, 2017
| @@ -26,6 +26,7 @@ const isSupportTouch = 'ontouchstart' in document; | |||
| const EVENT_TOUCHSTART = isSupportTouch ? 'touchstart' : 'mousedown'; | |||
| const EVENT_TOUCHMOVE = isSupportTouch ? 'touchmove' : 'mousemove'; | |||
| const EVENT_TOUCHEND = isSupportTouch ? 'touchend' : 'mouseup'; | |||
| const TOUCH_ALLOW_RANGE = 10; | |||
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| const distanceY = e.clientY - touchY; | ||
| const hypotenuse = Math.sqrt(Math.pow(distanceX, 2) + Math.pow(distanceY, 2)); | ||
| if (hypotenuse <= TOUCH_ALLOW_RANGE) { | ||
| console.log('yes'); |
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| const distanceX = e.clientX - touchX; | ||
| const distanceY = e.clientY - touchY; | ||
| const hypotenuse = Math.sqrt(Math.pow(distanceX, 2) + Math.pow(distanceY, 2)); | ||
| if (hypotenuse <= TOUCH_ALLOW_RANGE) { |
There was a problem hiding this comment.
例外やイレギュラーケースに対する処理を序盤に記述してから正常系に対する処理を記述する、って書き方が良いとされているよ◎
// BAD
foo(obj) {
if (obj.a && obj.b && !obj.c) {
console.log('OK');
}
}// GOOD
foo(obj) {
if (!obj.a) {
return;
}
if (!obj.b) {
return;
}
if (obj.c) {
return;
}
console.log('OK');
}
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| // bind済みであれば何もしない。 | ||
| if (!!elm.getAttribute('touchevents')) { | ||
| return; | ||
| } | ||
|
|
||
| const touchStartEventId = closureEventListener.add(elm, EVENT_TOUCHSTART, e => { | ||
| e.stopPropagation(); | ||
| touchX = e.clientX; |
There was a problem hiding this comment.
e.clientX これはデスクトップPC等のマウス系操作が行われる環境では使用可能なプロパティだけど、モバイルデバイス等のタッチ系操作が行われる環境では使用可能だろうか？？
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| e.currentTarget.classList.add('hover'); | ||
| }); | ||
|
|
||
| const touchMoveEventId = closureEventListener.add(elm, EVENT_TOUCHMOVE, e => { | ||
| e.stopPropagation(); | ||
| const isPressed = e.currentTarget.classList.contains('hover'); |
There was a problem hiding this comment.
既存コードが削除されてるけど、意図的な削除だろうか？
|
問題解決へのアプローチはOKっす◎ 口頭でstartとend時の座標を参照すればOKって伝えたけど、↑のケースに対応するためにmoveを上手に活用する必要ありだね。。ごめんw |
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| e.currentTarget.classList.add('hover'); | ||
| }); | ||
|
|
||
| const touchMoveEventId = closureEventListener.add(elm, EVENT_TOUCHMOVE, e => { | ||
| e.stopPropagation(); | ||
| const isPressed = e.currentTarget.classList.contains('hover'); | ||
| if (!isPressed) { | ||
| e.currentTarget.classList.remove('hover'); |
cathcheeno
reviewed
Aug 2, 2017
src/core/mixin.js
Outdated
| // bind済みであれば何もしない。 | ||
| if (!!elm.getAttribute('touchevents')) { | ||
| return; | ||
| } | ||
|
|
||
| const touchStartEventId = closureEventListener.add(elm, EVENT_TOUCHSTART, e => { | ||
| e.stopPropagation(); | ||
| if (isSupportTouch) { | ||
| console.log(e.touches[0]); |
There was a problem hiding this comment.
consoleを消す。
eslintでconsole設定入れるとか。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Buttons allows touch Event that moves 10px.