Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move npm publish to github action #809

Merged
merged 8 commits into from
Feb 9, 2024
Merged

move npm publish to github action #809

merged 8 commits into from
Feb 9, 2024
+343 −8

Conversation

taitasu555
Copy link
Contributor

@taitasu555 taitasu555 commented Feb 9, 2024 •
edited
Loading

Summary

  • move cicd to GitHub action
  • fix flaky test
  • fix dependencies for Mongoose

I already released the alpha SDK and debugged it and it works fine.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b63df47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nonoakij nonoakij self-requested a review February 9, 2024 08:28
mugioka
mugioka requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@mugioka mugioka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz file rename from .github/workflows/package-nodejs-viorn-lib-publich.yml to .github/workflows/publish-package-viorn-lib.yml.

.github/workflows/package-nodejs-viorn-lib-publich.yml Outdated Show resolved Hide resolved
@nonoakij nonoakij merged commit 966a88f into develop Feb 9, 2024
@nonoakij nonoakij deleted the feat-move-github-action branch February 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonoakij nonoakij nonoakij left review comments

@mugioka mugioka mugioka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taitasu555 @nonoakij @mugioka