manifest/v2s1: add get_labels() method, test and example
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveej
force-pushed
the
examples-image-labels
branch
3 times, most recently
from
b59cc22
to
25dc0f7
Compare
lucab
reviewed
Nov 8, 2018
|
I'm not opposed to this, but it seems to encode quite a bit of docker black magic which should be recorded somewhere (an inline comment is fine). |
steveej
changed the title
get_labels() method and exampleget_labels() method, test and example
|
I think we can skip the network test for this one. I've |
steveej
changed the title
get_labels() method, test and exampleget_labels() method, test and example
lucab
reviewed
Nov 8, 2018
steveej
force-pushed
the
examples-image-labels
branch
from
b6699b3
to
2773c41
Compare
lucab
approved these changes
Nov 8, 2018
steveej
force-pushed
the
examples-image-labels
branch
from
2feb01b
to
d8b7f40
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix (v2s1 only) for #57.