-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable image modality for ChatAgent
#473
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ChatAgent
ChatAgent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zechengz, it looks awesome. However, becuase it affects main data model BaseMessage
, we may want all maintainers to look into it. @camel-ai/camel-maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, normally we also require test for the example file, could you also add this?
@Wendong-Fan I create a mock test instead as it costs relatively a lot for using the vision model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I reviewed it and have left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok to me.
Thank @zechengz for the amazing implementation!! Some questions to discuss:
|
Hey @lightaime , I agree with you, we can remove One more suggestion after I read the latest OpenAI doc, we can also add parameter
|
@lightaime @Wendong-Fan SGTM, will create another PR for these. |
Hey @zechengz , I create a new issue, let's work on this together with @ocss884 to refactor it |
Description
Enable image modality for
ChatAgent
. Notice that only tested with single step chat agent, which means that the assistant agent just perform onestep
given some images etc.Motivation and Context
Part of #454
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
BaseMessage
ChatGPTVisionConfig
as the vision model config is different from the text oneChecklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!